Skip to content

x/tools/internal/lsp: race detected in TestLSP #54214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
findleyr opened this issue Aug 3, 2022 · 1 comment
Closed

x/tools/internal/lsp: race detected in TestLSP #54214

findleyr opened this issue Aug 3, 2022 · 1 comment
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.

Comments

@findleyr
Copy link
Member

findleyr commented Aug 3, 2022

Failure here:
https://build.golang.org/log/927c2103551010f213d6fbd0e8afa80897bca0bb

Looks like a straightforward (and real) data race: we should only access view options with the View.Options() method.

CC @dle8
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Aug 3, 2022
@findleyr findleyr self-assigned this Aug 3, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/420954 mentions this issue: internal/lsp/cache: fix data races to view.options

@findleyr findleyr mentioned this issue Aug 5, 2022
Closed
@dmitshur dmitshur changed the title golang.org/x/tools/internal/lsp: race detected in TestLSP x/tools/internal/lsp: race detected in TestLSP Aug 5, 2022
@golang golang locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @findleyr