Skip to content

Add go://linkname annotation for lrita/numa #71662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geraldss opened this issue Feb 11, 2025 · 1 comment
Closed

Add go://linkname annotation for lrita/numa #71662

geraldss opened this issue Feb 11, 2025 · 1 comment

Comments

@geraldss
Copy link

I'm getting a link error building lrita/numa:

link: github.com/lrita/numa: invalid reference to runtime.gostringnocopy

Per #67401, please add an annotation for https://github.com/lrita/numa so that it can build with Go 1.23+.

@ianlancetaylor
Copy link
Member

Sorry, but according to https://pkg.go.dev/github.com/lrita/numa that package is only imported by two other packages. That doesn't meet our criteria for locking down a runtime interface that nobody should ever use.

Also when I look at the current sources of that package, I don't see any reference to runtime.gostringnocopy. I do see a local copy of that function.

And with current Go it's also trivial to change the code to use unsafe.String instead.

@ianlancetaylor ianlancetaylor closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants