Skip to content

Commit f81960b

Browse files
committed
Implement WriterTo
Avoids allocation/copy when writing byteview to a writer.
1 parent 72d04f9 commit f81960b

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

byteview.go

+15
Original file line numberDiff line numberDiff line change
@@ -158,3 +158,18 @@ func (v ByteView) ReadAt(p []byte, off int64) (n int, err error) {
158158
}
159159
return
160160
}
161+
162+
// WriteTo implements io.WriterTo on the bytes in v.
163+
func (v ByteView) WriteTo(w io.Writer) (n int64, err error) {
164+
var m int
165+
if v.b != nil {
166+
m, err = w.Write(v.b)
167+
} else {
168+
m, err = io.WriteString(w, v.s)
169+
}
170+
if err == nil && m < v.Len() {
171+
err = io.ErrShortWrite
172+
}
173+
n = int64(m)
174+
return
175+
}

byteview_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package groupcache
1818

1919
import (
20+
"bytes"
2021
"fmt"
2122
"io"
2223
"io/ioutil"
@@ -47,6 +48,10 @@ func TestByteView(t *testing.T) {
4748
if got, err := ioutil.ReadAll(io.NewSectionReader(v, 0, int64(len(s)))); err != nil || string(got) != s {
4849
t.Errorf("%s: SectionReader of ReaderAt = %q, %v; want %q", name, got, err, s)
4950
}
51+
var dest bytes.Buffer
52+
if _, err := v.WriteTo(&dest); err != nil || !bytes.Equal(dest.Bytes(), []byte(s)) {
53+
t.Errorf("%s: WriteTo = %q, %v; want %q", name, dest.Bytes(), err, s)
54+
}
5055
}
5156
}
5257
}

0 commit comments

Comments
 (0)