Skip to content

Commit da12580

Browse files
committed
go/packages: NeedTypes implies NeedModule
Add NeedModule to the implied LoadMode when NeedTypes is set. (go/types.Config).GoVersion is populated from lpkg.Module.GoVersion. Fixes golang/go#67431 Change-Id: I4bde9b1c7f7ccf68ac6fe403c36aa139f9a7aa7f Reviewed-on: https://go-review.googlesource.com/c/tools/+/597875 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Matloob <[email protected]>
1 parent 6f4e2a8 commit da12580

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

go/packages/packages.go

+4
Original file line numberDiff line numberDiff line change
@@ -1499,6 +1499,10 @@ func impliedLoadMode(loadMode LoadMode) LoadMode {
14991499
// All these things require knowing the import graph.
15001500
loadMode |= NeedImports
15011501
}
1502+
if loadMode&NeedTypes != 0 {
1503+
// Types require the GoVersion from Module.
1504+
loadMode |= NeedModule
1505+
}
15021506

15031507
return loadMode
15041508
}

0 commit comments

Comments
 (0)