Skip to content

Commit 2a9fb96

Browse files
committed
src/welcome: mention that dlv-dap is the default debug adapter
Minor change: Add the link to stackoverflow (Questions) in the welcome page. The welcome page will show only with v0.27.0 or in preview mode. Updates #1657 Change-Id: Ia2d1f5e2520ae96a5dc3cbb287a1695490392a54 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/339099 Trust: Hyang-Ah Hana Kim <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: kokoro <[email protected]> Reviewed-by: Suzy Mueller <[email protected]>
1 parent a6066b7 commit 2a9fb96

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

src/goMain.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -710,10 +710,10 @@ If you would like additional configuration for diagnostics from gopls, please se
710710
function showGoWelcomePage(ctx: vscode.ExtensionContext) {
711711
// Update this list of versions when there is a new version where we want to
712712
// show the welcome page on update.
713-
const showVersions: string[] = ['0.22.0'];
713+
const showVersions: string[] = ['0.27.0'];
714714
// TODO(hyangah): use the content hash instead of hard-coded string.
715715
// https://github.com/golang/vscode-go/issue/1179
716-
let goExtensionVersion = '0.22.0';
716+
let goExtensionVersion = '0.27.0';
717717
let goExtensionVersionKey = 'go.extensionVersion';
718718
if (isInPreviewMode()) {
719719
goExtensionVersion = '0.0.0';

src/welcome.ts

+15
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ export class WelcomePanel {
108108
// Local path to css styles and images
109109
const scriptPathOnDisk = joinPath(this.dataroot, 'welcome.js');
110110
const stylePath = joinPath(this.dataroot, 'welcome.css');
111+
const announcePath = vscode.Uri.joinPath(this.dataroot, 'announce.png');
111112
const gopherPath = joinPath(this.dataroot, 'go-logo-blue.png');
112113
const goExtension = vscode.extensions.getExtension(extensionId)!;
113114
const goExtensionVersion = goExtension.packageJSON.version;
@@ -116,6 +117,7 @@ export class WelcomePanel {
116117
const scriptURI = webview.asWebviewUri(scriptPathOnDisk);
117118
const stylesURI = webview.asWebviewUri(stylePath);
118119
const gopherURI = webview.asWebviewUri(gopherPath);
120+
const announceURI = webview.asWebviewUri(announcePath);
119121

120122
// Use a nonce to only allow specific scripts to be run
121123
const nonce = getNonce();
@@ -147,11 +149,24 @@ export class WelcomePanel {
147149
-->
148150
<li><a href="#" class="Command" data-command="openDocument" data-document="CHANGELOG.md">Release notes</a></li>
149151
<li><a href="https://github.com/golang/vscode-go">GitHub</a></li>
152+
<li><a href="https://stackoverflow.com/questions/tagged/go+visual-studio-code">Questions</a></li>
150153
<li><a href="https://invite.slack.golangbridge.org/">Slack</a></li>
151154
</ul>
152155
</div>
153156
</div>
154157
158+
<div class="Announcement">
159+
<img src="${announceURI}" alt="announce" class="Announcement-image" />
160+
<p>
161+
Heads up!
162+
The extension now uses Delve's native DAP implementation (<a href="https://github.com/go-delve/delve/blob/master/Documentation/usage/dlv_dap.md">dlv-dap</a>)
163+
for local debugging. We updated the <a href="https://github.com/golang/vscode-go/blob/master/docs/debugging.md">
164+
Documentation for Debugging</a> to show the new features available with dlv-dap.
165+
This change does not apply to remote debugging yet. For remote debugging, keep following
166+
the instruction in the <a href="https://github.com/golang/vscode-go/blob/master/docs/debugging-legacy.md">old documentation</a>.
167+
</p>
168+
</div>
169+
155170
<div class="Cards">
156171
<div class="Card">
157172
<div class="Card-inner">

0 commit comments

Comments
 (0)