internal/report: refactor fix to avoid nil pointer

Split Fix into FixText (which doesn't require a proxy client) and
FixVersions (which does), and only call the FixText portion from
applySuggestion in vulnreport. This avoids a possible nil pointer
dereference.

Change-Id: Ic57cb0738ac64ce892e62c2e16c76efb25c22147
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/562245
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Damien Neil <[email protected]>

Author: tatianab

cmd/vulnreport/suggest.go

@@ -130,5 +130,5 @@ func suggestions(ctx context.Context, c genai.Client, r *report.Report, max int)
 func applySuggestion(r *report.Report, s *genai.Suggestion) {
 	r.Summary = report.Summary(s.Summary)
 	r.Description = report.Description(s.Description)
-	r.Fix(nil)
+	r.FixText()
 }

internal/report/fix.go

@@ -17,12 +17,13 @@ import (
 )
 
 func (r *Report) Fix(pc *proxy.Client) {
-	for _, ref := range r.References {
-		ref.URL = fixURL(ref.URL)
-	}
 	for _, m := range r.Modules {
 		m.FixVersions(pc)
 	}
+	r.FixText()
+}
+
+func (r *Report) FixText() {
 	fixLines := func(sp *string) {
 		*sp = fixLineLength(*sp, maxLineLength)
 	}
@@ -31,6 +32,9 @@ func (r *Report) Fix(pc *proxy.Client) {
 	if r.CVEMetadata != nil {
 		fixLines(&r.CVEMetadata.Description)
 	}
+	for _, ref := range r.References {
+		ref.URL = fixURL(ref.URL)
+	}
 }
 
 // FixVersions replaces each version with its canonical form (if possible),