-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
/
Copy pathnolintlint.go
232 lines (191 loc) · 6.87 KB
/
nolintlint.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
// Package internal provides a linter to ensure that all //nolint directives are followed by explanations
package internal
import (
"go/token"
"regexp"
"strings"
"golang.org/x/tools/go/analysis"
"github.com/golangci/golangci-lint/pkg/goanalysis"
"github.com/golangci/golangci-lint/pkg/result"
)
const LinterName = "nolintlint"
const (
NeedsMachineOnly Needs = 1 << iota
NeedsSpecific
NeedsExplanation
NeedsUnused
NeedsAll = NeedsMachineOnly | NeedsSpecific | NeedsExplanation
)
type Needs uint
const commentMark = "//"
var commentPattern = regexp.MustCompile(`^//\s*(nolint)(:\s*[\w-]+\s*(?:,\s*[\w-]+\s*)*)?\b`)
// matches a complete nolint directive
var fullDirectivePattern = regexp.MustCompile(`^//\s*nolint(?::(\s*[\w-]+\s*(?:,\s*[\w-]+\s*)*))?\s*(//.*)?\s*\n?$`)
type Linter struct {
needs Needs // indicates which linter checks to perform
excludeByLinter map[string]bool
}
// NewLinter creates a linter that enforces that the provided directives fulfill the provided requirements
func NewLinter(needs Needs, excludes []string) (*Linter, error) {
excludeByName := make(map[string]bool)
for _, e := range excludes {
excludeByName[e] = true
}
return &Linter{
needs: needs | NeedsMachineOnly,
excludeByLinter: excludeByName,
}, nil
}
var (
leadingSpacePattern = regexp.MustCompile(`^//(\s*)`)
trailingBlankExplanation = regexp.MustCompile(`\s*(//\s*)?$`)
)
//nolint:funlen,gocyclo // the function is going to be refactored in the future
func (l Linter) Run(pass *analysis.Pass) ([]goanalysis.Issue, error) {
var issues []goanalysis.Issue
for _, file := range pass.Files {
for _, c := range file.Comments {
for _, comment := range c.List {
if !commentPattern.MatchString(comment.Text) {
continue
}
// check for a space between the "//" and the directive
leadingSpaceMatches := leadingSpacePattern.FindStringSubmatch(comment.Text)
var leadingSpace string
if len(leadingSpaceMatches) > 0 {
leadingSpace = leadingSpaceMatches[1]
}
directiveWithOptionalLeadingSpace := commentMark
if leadingSpace != "" {
directiveWithOptionalLeadingSpace += " "
}
split := strings.Split(strings.SplitN(comment.Text, ":", 2)[0], commentMark)
directiveWithOptionalLeadingSpace += strings.TrimSpace(split[1])
pos := pass.Fset.Position(comment.Pos())
end := pass.Fset.Position(comment.End())
// check for, report and eliminate leading spaces, so we can check for other issues
if leadingSpace != "" {
removeWhitespace := []analysis.SuggestedFix{{
TextEdits: []analysis.TextEdit{{
Pos: token.Pos(pos.Offset),
End: token.Pos(pos.Offset + len(commentMark) + len(leadingSpace)),
NewText: []byte(commentMark),
}},
}}
if (l.needs & NeedsMachineOnly) != 0 {
issue := &result.Issue{
FromLinter: LinterName,
Text: formatNotMachine(comment.Text),
Pos: pos,
SuggestedFixes: removeWhitespace,
}
issues = append(issues, goanalysis.NewIssue(issue, pass))
} else if len(leadingSpace) > 1 {
issue := &result.Issue{
FromLinter: LinterName,
Text: formatExtraLeadingSpace(comment.Text),
Pos: pos,
SuggestedFixes: removeWhitespace,
}
issues = append(issues, goanalysis.NewIssue(issue, pass))
}
}
fullMatches := fullDirectivePattern.FindStringSubmatch(comment.Text)
if len(fullMatches) == 0 {
issue := &result.Issue{
FromLinter: LinterName,
Text: formatParseError(comment.Text, directiveWithOptionalLeadingSpace),
Pos: pos,
}
issues = append(issues, goanalysis.NewIssue(issue, pass))
continue
}
lintersText, explanation := fullMatches[1], fullMatches[2]
var linters []string
if lintersText != "" && !strings.HasPrefix(lintersText, "all") {
lls := strings.Split(lintersText, ",")
linters = make([]string, 0, len(lls))
rangeStart := (pos.Column - 1) + len(commentMark) + len(leadingSpace) + len("nolint:")
for i, ll := range lls {
rangeEnd := rangeStart + len(ll)
if i < len(lls)-1 {
rangeEnd++ // include trailing comma
}
trimmedLinterName := strings.TrimSpace(ll)
if trimmedLinterName != "" {
linters = append(linters, trimmedLinterName)
}
rangeStart = rangeEnd
}
}
if (l.needs & NeedsSpecific) != 0 {
if len(linters) == 0 {
issue := &result.Issue{
FromLinter: LinterName,
Text: formatNotSpecific(comment.Text, directiveWithOptionalLeadingSpace),
Pos: pos,
}
issues = append(issues, goanalysis.NewIssue(issue, pass))
}
}
// when detecting unused directives, we send all the directives through and filter them out in the nolint processor
if (l.needs & NeedsUnused) != 0 {
removeNolintCompletely := []analysis.SuggestedFix{{
TextEdits: []analysis.TextEdit{{
Pos: token.Pos(pos.Offset),
End: token.Pos(end.Offset),
NewText: nil,
}},
}}
if len(linters) == 0 {
issue := &result.Issue{
FromLinter: LinterName,
Text: formatUnusedCandidate(comment.Text, ""),
Pos: pos,
ExpectNoLint: true,
SuggestedFixes: removeNolintCompletely,
}
issues = append(issues, goanalysis.NewIssue(issue, pass))
} else {
for _, linter := range linters {
issue := &result.Issue{
FromLinter: LinterName,
Text: formatUnusedCandidate(comment.Text, linter),
Pos: pos,
ExpectNoLint: true,
ExpectedNoLintLinter: linter,
}
// only offer SuggestedFix if there is a single linter
// because of issues around commas and the possibility of all
// linters being removed
if len(linters) == 1 {
issue.SuggestedFixes = removeNolintCompletely
}
issues = append(issues, goanalysis.NewIssue(issue, pass))
}
}
}
if (l.needs&NeedsExplanation) != 0 && (explanation == "" || strings.TrimSpace(explanation) == commentMark) {
needsExplanation := len(linters) == 0 // if no linters are mentioned, we must have explanation
// otherwise, check if we are excluding all the mentioned linters
for _, ll := range linters {
if !l.excludeByLinter[ll] { // if a linter does require explanation
needsExplanation = true
break
}
}
if needsExplanation {
fullDirectiveWithoutExplanation := trailingBlankExplanation.ReplaceAllString(comment.Text, "")
issue := &result.Issue{
FromLinter: LinterName,
Text: formatNoExplanation(comment.Text, fullDirectiveWithoutExplanation),
Pos: pos,
}
issues = append(issues, goanalysis.NewIssue(issue, pass))
}
}
}
}
}
return issues, nil
}