Skip to content

Commit 11cdef8

Browse files
committed
upgarde asasalint v0.0.6, and add some note in reference.yml
1 parent 43ef93c commit 11cdef8

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

Diff for: .golangci.reference.yml

+8-4
Original file line numberDiff line numberDiff line change
@@ -108,17 +108,21 @@ output:
108108
# All available settings of specific linters.
109109
linters-settings:
110110
asasalint:
111-
# Add FuncName to exclude for some bad case report.
111+
# Add FuncName to exclude for avoid some bad case report.
112+
# the asasalint has also some builtin exclude func names, not need to config here,
113+
# and can disabled by `no-builtin-exclude` option.
114+
# they are `Printf,Println,Fprintf,Fprintln,Fatal,Fatalf,Panic,Panicf,Panicln,Print,Printf,Println,Sprintf,Sprintln,Error,Errorf,Info,Infof,Warn,Warnf,Debug,Debugf`.
112115
# Default: []
113116
exclude:
114117
- Append
115118
- Log
116119
# ignore found case in *_test.go file
117120
# Default: false
118-
ignore-in-test: false
119-
# if true, will disable the default exclude see https://github.com/alingse/asasalint/blob/main/asasalint.go#L15 like: Printf,Println,Errorf,Debugf ...
121+
ignore-in-test: true
122+
# if true, will disable the builtin exclude see https://github.com/alingse/asasalint/blob/main/asasalint.go#L15 like: Printf,Println,Errorf,Debugf ...
120123
# Default: false
121-
no-default-exclude: false
124+
no-builtin-exclude: true
125+
122126
bidichk:
123127
# The following configurations check for all mentioned invisible unicode runes.
124128
# All runes are enabled by default.

Diff for: go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
github.com/GaijinEntertainment/go-exhaustruct/v2 v2.2.0
1212
github.com/OpenPeeDeeP/depguard v1.1.0
1313
github.com/alexkohler/prealloc v1.0.0
14-
github.com/alingse/asasalint v0.0.5
14+
github.com/alingse/asasalint v0.0.6
1515
github.com/ashanbrown/forbidigo v1.3.0
1616
github.com/ashanbrown/makezero v1.1.1
1717
github.com/bkielbasa/cyclop v1.2.0

Diff for: go.sum

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: pkg/config/linters_settings.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ type LintersSettings struct {
188188
type AsasalintSettings struct {
189189
Exclude []string `mapstructure:"exclude"`
190190
IgnoreInTest bool `mapstructure:"ignore-in-test"`
191-
NoDefaultExclude bool `mapstructure:"no-default-exclude"`
191+
NoBuiltinExclude bool `mapstructure:"no-builtin-exclude"`
192192
}
193193

194194
type BiDiChkSettings struct {

Diff for: pkg/golinters/asasalint.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ func NewAsasalint(setting *config.AsasalintSettings) *goanalysis.Linter {
1313
if setting != nil {
1414
cfg.Exclude = setting.Exclude
1515
cfg.IgnoreInTest = setting.IgnoreInTest
16-
cfg.NoDefaultExclude = setting.NoDefaultExclude
16+
cfg.NoBuiltinExclude = setting.NoBuiltinExclude
1717
}
1818

1919
a := asasalint.NewAnalyzer(cfg)

0 commit comments

Comments
 (0)