linter: add gostrconv

Author: catenacyber

.golangci.reference.yml

@@ -2301,6 +2301,7 @@ linters:
     - nosnakecase
     - nosprintfhostport
     - paralleltest
+    - perfsprint
     - prealloc
     - predeclared
     - promlinter
@@ -2420,6 +2421,7 @@ linters:
     - nosnakecase
     - nosprintfhostport
     - paralleltest
+    - perfsprint
     - prealloc
     - predeclared
     - promlinter

go.mod

@@ -27,6 +27,7 @@ require (
 	github.com/breml/errchkjson v0.3.6
 	github.com/butuzov/ireturn v0.2.1
 	github.com/butuzov/mirror v1.1.0
+	github.com/catenacyber/perfsprint v0.2.0
 	github.com/charithe/durationcheck v0.0.10
 	github.com/curioswitch/go-reassign v0.2.0
 	github.com/daixiang0/gci v0.11.2

go.sum

@@ -0,0 +1,17 @@
+package golinters
+
+import (
+	"github.com/catenacyber/perfsprint/analyzer"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewGoStrconv() *goanalysis.Linter {
+	return goanalysis.NewLinter(
+		"perfsprint",
+		"Checks usages of `fmt.Sprintf` which have faster alternatives.",
+		[]*analysis.Analyzer{analyzer.Analyzer},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/perfsprint.go

@@ -712,6 +712,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle, linter.PresetTest).
 			WithURL("https://github.com/kunwardeep/paralleltest"),
 
+		linter.NewConfig(golinters.NewPerfSprint()).
+			WithSince("v1.54.2").
+			WithPresets(linter.PresetStyle).
+			WithURL("https://github.com/catenacyber/perfsprint"),
+
 		linter.NewConfig(golinters.NewPreAlloc(preallocCfg)).
 			WithSince("v1.19.0").
 			WithPresets(linter.PresetPerformance).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,8 @@
+//golangcitest:args -Eperfsprint
+package testdata
+
+import "fmt"
+
+func SprintfCouldBeStrconv() {
+	fmt.Sprintf("%d", 42) // want "Sprintf can be replaced with faster strconv.Itoa"
+}