Skip to content

Commit 6194858

Browse files
authored
dev: jsonschema support for revive comment directives (#5448)
1 parent 336b21b commit 6194858

11 files changed

+246
-0
lines changed

Diff for: .golangci.next.reference.yml

+6
Original file line numberDiff line numberDiff line change
@@ -2386,6 +2386,12 @@ linters-settings:
23862386
# Default: false
23872387
enable-all-rules: true
23882388

2389+
# Enable validation of comment directives.
2390+
# See https://github.com/mgechev/revive#comment-directives
2391+
directives:
2392+
- name: specify-disable-reason
2393+
severity: error
2394+
23892395
# Sets the default failure confidence.
23902396
# This means that linting errors with less than 0.8 confidence will be ignored.
23912397
# Default: 0.8

Diff for: .golangci.reference.yml

+6
Original file line numberDiff line numberDiff line change
@@ -2386,6 +2386,12 @@ linters-settings:
23862386
# Default: false
23872387
enable-all-rules: true
23882388

2389+
# Enable validation of comment directives.
2390+
# See https://github.com/mgechev/revive#comment-directives
2391+
directives:
2392+
- name: specify-disable-reason
2393+
severity: error
2394+
23892395
# Sets the default failure confidence.
23902396
# This means that linting errors with less than 0.8 confidence will be ignored.
23912397
# Default: 0.8

Diff for: jsonschema/golangci.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2657,6 +2657,32 @@
26572657
"type": "boolean",
26582658
"default": false
26592659
},
2660+
"directives": {
2661+
"type": "array",
2662+
"items": {
2663+
"type": "object",
2664+
"additionalProperties": false,
2665+
"properties": {
2666+
"name": {
2667+
"type": "string",
2668+
"enum": ["specify-disable-reason"]
2669+
},
2670+
"severity": {
2671+
"type": "string",
2672+
"enum": ["warning", "error"]
2673+
},
2674+
"exclude": {
2675+
"type": "array",
2676+
"items": {
2677+
"type": "string"
2678+
}
2679+
},
2680+
"arguments": {
2681+
"type": "array"
2682+
}
2683+
}
2684+
}
2685+
},
26602686
"rules": {
26612687
"type": "array",
26622688
"items": {

Diff for: jsonschema/golangci.next.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2657,6 +2657,32 @@
26572657
"type": "boolean",
26582658
"default": false
26592659
},
2660+
"directives": {
2661+
"type": "array",
2662+
"items": {
2663+
"type": "object",
2664+
"additionalProperties": false,
2665+
"properties": {
2666+
"name": {
2667+
"type": "string",
2668+
"enum": ["specify-disable-reason"]
2669+
},
2670+
"severity": {
2671+
"type": "string",
2672+
"enum": ["warning", "error"]
2673+
},
2674+
"exclude": {
2675+
"type": "array",
2676+
"items": {
2677+
"type": "string"
2678+
}
2679+
},
2680+
"arguments": {
2681+
"type": "array"
2682+
}
2683+
}
2684+
}
2685+
},
26602686
"rules": {
26612687
"type": "array",
26622688
"items": {

Diff for: jsonschema/golangci.v1.57.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2209,6 +2209,32 @@
22092209
"type": "boolean",
22102210
"default": false
22112211
},
2212+
"directives": {
2213+
"type": "array",
2214+
"items": {
2215+
"type": "object",
2216+
"additionalProperties": false,
2217+
"properties": {
2218+
"name": {
2219+
"type": "string",
2220+
"enum": ["specify-disable-reason"]
2221+
},
2222+
"severity": {
2223+
"type": "string",
2224+
"enum": ["warning", "error"]
2225+
},
2226+
"exclude": {
2227+
"type": "array",
2228+
"items": {
2229+
"type": "string"
2230+
}
2231+
},
2232+
"arguments": {
2233+
"type": "array"
2234+
}
2235+
}
2236+
}
2237+
},
22122238
"rules": {
22132239
"type": "array",
22142240
"items": {

Diff for: jsonschema/golangci.v1.58.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2380,6 +2380,32 @@
23802380
"type": "boolean",
23812381
"default": false
23822382
},
2383+
"directives": {
2384+
"type": "array",
2385+
"items": {
2386+
"type": "object",
2387+
"additionalProperties": false,
2388+
"properties": {
2389+
"name": {
2390+
"type": "string",
2391+
"enum": ["specify-disable-reason"]
2392+
},
2393+
"severity": {
2394+
"type": "string",
2395+
"enum": ["warning", "error"]
2396+
},
2397+
"exclude": {
2398+
"type": "array",
2399+
"items": {
2400+
"type": "string"
2401+
}
2402+
},
2403+
"arguments": {
2404+
"type": "array"
2405+
}
2406+
}
2407+
}
2408+
},
23832409
"rules": {
23842410
"type": "array",
23852411
"items": {

Diff for: jsonschema/golangci.v1.59.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2463,6 +2463,32 @@
24632463
"type": "boolean",
24642464
"default": false
24652465
},
2466+
"directives": {
2467+
"type": "array",
2468+
"items": {
2469+
"type": "object",
2470+
"additionalProperties": false,
2471+
"properties": {
2472+
"name": {
2473+
"type": "string",
2474+
"enum": ["specify-disable-reason"]
2475+
},
2476+
"severity": {
2477+
"type": "string",
2478+
"enum": ["warning", "error"]
2479+
},
2480+
"exclude": {
2481+
"type": "array",
2482+
"items": {
2483+
"type": "string"
2484+
}
2485+
},
2486+
"arguments": {
2487+
"type": "array"
2488+
}
2489+
}
2490+
}
2491+
},
24662492
"rules": {
24672493
"type": "array",
24682494
"items": {

Diff for: jsonschema/golangci.v1.60.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2469,6 +2469,32 @@
24692469
"type": "boolean",
24702470
"default": false
24712471
},
2472+
"directives": {
2473+
"type": "array",
2474+
"items": {
2475+
"type": "object",
2476+
"additionalProperties": false,
2477+
"properties": {
2478+
"name": {
2479+
"type": "string",
2480+
"enum": ["specify-disable-reason"]
2481+
},
2482+
"severity": {
2483+
"type": "string",
2484+
"enum": ["warning", "error"]
2485+
},
2486+
"exclude": {
2487+
"type": "array",
2488+
"items": {
2489+
"type": "string"
2490+
}
2491+
},
2492+
"arguments": {
2493+
"type": "array"
2494+
}
2495+
}
2496+
}
2497+
},
24722498
"rules": {
24732499
"type": "array",
24742500
"items": {

Diff for: jsonschema/golangci.v1.61.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2474,6 +2474,32 @@
24742474
"type": "boolean",
24752475
"default": false
24762476
},
2477+
"directives": {
2478+
"type": "array",
2479+
"items": {
2480+
"type": "object",
2481+
"additionalProperties": false,
2482+
"properties": {
2483+
"name": {
2484+
"type": "string",
2485+
"enum": ["specify-disable-reason"]
2486+
},
2487+
"severity": {
2488+
"type": "string",
2489+
"enum": ["warning", "error"]
2490+
},
2491+
"exclude": {
2492+
"type": "array",
2493+
"items": {
2494+
"type": "string"
2495+
}
2496+
},
2497+
"arguments": {
2498+
"type": "array"
2499+
}
2500+
}
2501+
}
2502+
},
24772503
"rules": {
24782504
"type": "array",
24792505
"items": {

Diff for: jsonschema/golangci.v1.62.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2528,6 +2528,32 @@
25282528
"type": "boolean",
25292529
"default": false
25302530
},
2531+
"directives": {
2532+
"type": "array",
2533+
"items": {
2534+
"type": "object",
2535+
"additionalProperties": false,
2536+
"properties": {
2537+
"name": {
2538+
"type": "string",
2539+
"enum": ["specify-disable-reason"]
2540+
},
2541+
"severity": {
2542+
"type": "string",
2543+
"enum": ["warning", "error"]
2544+
},
2545+
"exclude": {
2546+
"type": "array",
2547+
"items": {
2548+
"type": "string"
2549+
}
2550+
},
2551+
"arguments": {
2552+
"type": "array"
2553+
}
2554+
}
2555+
}
2556+
},
25312557
"rules": {
25322558
"type": "array",
25332559
"items": {

Diff for: jsonschema/golangci.v1.63.jsonschema.json

+26
Original file line numberDiff line numberDiff line change
@@ -2606,6 +2606,32 @@
26062606
"type": "boolean",
26072607
"default": false
26082608
},
2609+
"directives": {
2610+
"type": "array",
2611+
"items": {
2612+
"type": "object",
2613+
"additionalProperties": false,
2614+
"properties": {
2615+
"name": {
2616+
"type": "string",
2617+
"enum": ["specify-disable-reason"]
2618+
},
2619+
"severity": {
2620+
"type": "string",
2621+
"enum": ["warning", "error"]
2622+
},
2623+
"exclude": {
2624+
"type": "array",
2625+
"items": {
2626+
"type": "string"
2627+
}
2628+
},
2629+
"arguments": {
2630+
"type": "array"
2631+
}
2632+
}
2633+
}
2634+
},
26092635
"rules": {
26102636
"type": "array",
26112637
"items": {

0 commit comments

Comments
 (0)