runner: non-zero exit code when a linter produces a panic (#1979)

ldez · web-flow · commit 625445b1f559 · 2021-05-13T23:49:08.000+02:00
diff --git a/pkg/lint/runner.go b/pkg/lint/runner.go
@@ -108,10 +108,10 @@ func (r *Runner) runLinterSafe(ctx context.Context, lintCtx *linter.Context,
 				err = fmt.Errorf("%s: %w", lc.Name(), pe)
 
 				// Don't print stacktrace from goroutines twice
-				lintCtx.Log.Warnf("Panic: %s: %s", pe, pe.Stack())
+				r.Log.Errorf("Panic: %s: %s", pe, pe.Stack())
 			} else {
 				err = fmt.Errorf("panic occurred: %s", panicData)
-				r.Log.Warnf("Panic stack trace: %s", debug.Stack())
+				r.Log.Errorf("Panic stack trace: %s", debug.Stack())
 			}
 		}
 	}()

Original file line number	Diff line number	Diff line change
`@@ -108,10 +108,10 @@ func (r Runner) runLinterSafe(ctx context.Context, lintCtx linter.Context,`
`108`	`108`	`err = fmt.Errorf("%s: %w", lc.Name(), pe)`
`109`	`109`
`110`	`110`	`// Don't print stacktrace from goroutines twice`
`111`		`- lintCtx.Log.Warnf("Panic: %s: %s", pe, pe.Stack())`
	`111`	`+ r.Log.Errorf("Panic: %s: %s", pe, pe.Stack())`
`112`	`112`	`} else {`
`113`	`113`	`err = fmt.Errorf("panic occurred: %s", panicData)`
`114`		`- r.Log.Warnf("Panic stack trace: %s", debug.Stack())`
	`114`	`+ r.Log.Errorf("Panic stack trace: %s", debug.Stack())`
`115`	`115`	`}`
`116`	`116`	`}`
`117`	`117`	`}()`