Fix file leak in lll

jirfag · jirfag · commit 6dd4f07c50d1 · 2018-06-29T08:28:12.000+03:00
diff --git a/Makefile b/Makefile
@@ -1,4 +1,5 @@
 test:
+	go install ./cmd/...
 	GL_TEST_RUN=1 golangci-lint run -v
 	GL_TEST_RUN=1 golangci-lint run --fast --no-config -v
 	GL_TEST_RUN=1 golangci-lint run --no-config -v
diff --git a/pkg/golinters/lll.go b/pkg/golinters/lll.go
@@ -30,6 +30,7 @@ func (lint Lll) getIssuesForFile(filename string, maxLineLen int) ([]result.Issu
 	if err != nil {
 		return nil, fmt.Errorf("can't open file %s: %s", filename, err)
 	}
+	defer f.Close()
 
 	lineNumber := 1
 	scanner := bufio.NewScanner(f)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`test:`
	`2`	`+ go install ./cmd/...`
`2`	`3`	`GL_TEST_RUN=1 golangci-lint run -v`
`3`	`4`	`GL_TEST_RUN=1 golangci-lint run --fast --no-config -v`
`4`	`5`	`GL_TEST_RUN=1 golangci-lint run --no-config -v`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ func (lint Lll) getIssuesForFile(filename string, maxLineLen int) ([]result.Issu`
`30`	`30`	`if err != nil {`
`31`	`31`	`return nil, fmt.Errorf("can't open file %s: %s", filename, err)`
`32`	`32`	`}`
	`33`	`+ defer f.Close()`
`33`	`34`
`34`	`35`	`lineNumber := 1`
`35`	`36`	`scanner := bufio.NewScanner(f)`