chore: update CI and configuration

Author: ldez

.github/workflows/pr.yml

@@ -41,10 +41,11 @@ jobs:
           # - 1.18beta1 -> 1.18.0-beta.1
           # - 1.18rc1 -> 1.18.0-rc.1
           go-version: ${{ env.GO_VERSION }}
-      - name: lint
-        uses: golangci/[email protected]
-        with:
-          version: latest
+      # TODO(ldez): must add uncommented when [email protected] (with golangci-lint v2 support) will be created.
+#      - name: lint
+#        uses: golangci/[email protected]
+#        with:
+#          version: latest
 
   tests-on-windows:
     needs: golangci-lint # run after golangci-lint action to not produce duplicated errors
@@ -116,7 +117,7 @@ jobs:
 
   # Note: the command `run` is tested by the previous steps (`make test`).
   commands:
-    needs: golangci-lint
+    needs: golangci-lint # run after golangci-lint action to not produce duplicated errors
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -147,7 +148,8 @@ jobs:
 
       - run: ./golangci-lint config
       - run: ./golangci-lint config path
-      - run: ./golangci-lint config verify --schema jsonschema/golangci.jsonschema.json
+      # TODO(ldez) after v2: golangci.next.jsonschema.json -> golangci.jsonschema.json
+      - run: ./golangci-lint config verify --schema jsonschema/golangci.next.jsonschema.json
 
       - run: ./golangci-lint help
       - run: ./golangci-lint help linters

.golangci.yml

@@ -11,6 +11,8 @@
 #
 # See the file `.golangci.reference.yml` to have a list of all available configuration options.
 
+version: "2"
+
 linters:
   disable-all: true
   # This list of linters is not a recommendation (same thing for all this configuration file).
@@ -31,8 +33,6 @@ linters:
     - gocritic
     - gocyclo
     - godox
-    - gofmt
-    - goimports
     - mnd
     - goprintffuncname
     - gosec
@@ -53,7 +53,68 @@ linters:
     - unparam
     - unused
     - whitespace
+  exclusions:
+    presets:
+      - comments
+      - stdErrorHandling
+      - commonFalsePositives
+      - legacy
+    paths:
+      - test/testdata_etc # test files
+      - internal/go # extracted from Go code
+      - internal/x # extracted from x/tools code
+      - pkg/goformatters/gci/internal # extracted from gci code
+      - pkg/goanalysis/runner_checker.go # extracted from x/tools code
+    rules:
+      - path: (.+)_test\.go
+        linters:
+          - dupl
+          - mnd
+          - lll
+
+      # Deprecated linter options.
+      - path: pkg/golinters/errcheck/errcheck.go
+        linters: [staticcheck]
+        text: "SA1019: errCfg.Exclude is deprecated: use ExcludeFunctions instead"
+      - path: pkg/golinters/errcheck/errcheck.go
+        linters: [staticcheck]
+        text: "SA1019: errCfg.Ignore is deprecated: use ExcludeFunctions instead"
+      - path: pkg/golinters/govet/govet.go
+        linters: [staticcheck]
+        text: "SA1019: cfg.CheckShadowing is deprecated: the linter should be enabled inside Enable."
+      - path: pkg/golinters/godot/godot.go
+        linters: [staticcheck]
+        text: "SA1019: settings.CheckAll is deprecated: use Scope instead"
+      - path: pkg/goformatters/gci/gci.go
+        linters: [staticcheck]
+        text: "SA1019: settings.LocalPrefixes is deprecated: use Sections instead."
 
+      # Related to `run.go`, it cannot be removed.
+      - path: pkg/golinters/gofumpt/gofumpt.go
+        linters: [staticcheck]
+        text: "SA1019: settings.LangVersion is deprecated: use the global `run.go` instead."
+
+      # Based on existing code, the modifications should be limited to make maintenance easier.
+      - path: pkg/golinters/unused/unused.go
+        linters: [gocritic]
+        text: "rangeValCopy: each iteration copies 160 bytes \\(consider pointers or indexing\\)"
+
+      # Related to the result of computation but divided multiple times by 1024.
+      - path: test/bench/bench_test.go
+        linters: [gosec]
+        text: "G115: integer overflow conversion uint64 -> int"
+
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofmt:
+      rewrite-rules:
+        - pattern: 'interface{}'
+          replacement: 'any'
+    goimports:
+      local-prefixes: github.com/golangci/golangci-lint
 
 linters-settings:
   depguard:
@@ -95,12 +156,6 @@ linters-settings:
   godox:
     keywords:
       - FIXME
-  gofmt:
-    rewrite-rules:
-      - pattern: 'interface{}'
-        replacement: 'any'
-  goimports:
-    local-prefixes: github.com/golangci/golangci-lint
   mnd:
     # don't include the "operation" and "assign"
     checks:
@@ -146,53 +201,5 @@ linters-settings:
       - name: unused-parameter
       - name: unused-receiver
 
-issues:
-  exclude-rules:
-    - path: (.+)_test\.go
-      linters:
-        - dupl
-        - mnd
-        - lll
-
-    # Deprecated linter options.
-    - path: pkg/golinters/errcheck/errcheck.go
-      linters: [staticcheck]
-      text: "SA1019: errCfg.Exclude is deprecated: use ExcludeFunctions instead"
-    - path: pkg/golinters/errcheck/errcheck.go
-      linters: [staticcheck]
-      text: "SA1019: errCfg.Ignore is deprecated: use ExcludeFunctions instead"
-    - path: pkg/golinters/govet/govet.go
-      linters: [staticcheck]
-      text: "SA1019: cfg.CheckShadowing is deprecated: the linter should be enabled inside Enable."
-    - path: pkg/golinters/godot/godot.go
-      linters: [staticcheck]
-      text: "SA1019: settings.CheckAll is deprecated: use Scope instead"
-    - path: pkg/goformatters/gci/gci.go
-      linters: [staticcheck]
-      text: "SA1019: settings.LocalPrefixes is deprecated: use Sections instead."
-
-    # Related to `run.go`, it cannot be removed.
-    - path: pkg/golinters/gofumpt/gofumpt.go
-      linters: [staticcheck]
-      text: "SA1019: settings.LangVersion is deprecated: use the global `run.go` instead."
-
-    # Based on existing code, the modifications should be limited to make maintenance easier.
-    - path: pkg/golinters/unused/unused.go
-      linters: [gocritic]
-      text: "rangeValCopy: each iteration copies 160 bytes \\(consider pointers or indexing\\)"
-
-    # Related to the result of computation but divided multiple times by 1024.
-    - path: test/bench/bench_test.go
-      linters: [gosec]
-      text: "G115: integer overflow conversion uint64 -> int"
-
-  exclude-dirs:
-    - test/testdata_etc # test files
-    - internal/go # extracted from Go code
-    - internal/x # extracted from x/tools code
-    - pkg/goformatters/gci/internal # extracted from gci code
-  exclude-files:
-    - pkg/goanalysis/runner_checker.go # extracted from x/tools code
-
 run:
   timeout: 5m

pkg/commands/flagsets.go

@@ -126,7 +126,6 @@ func setupOutputFormatsFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
 		color.GreenString(outputPathDesc))
 }
 
-//nolint:gomnd // magic numbers here is ok
 func setupIssuesFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
 	internal.AddFlagAndBind(v, fs, fs.Int, "max-issues-per-linter", "issues.max-issues-per-linter", defaultMaxIssuesPerLinter,
 		color.GreenString("Maximum issues count per one linter. Set to 0 to disable"))

pkg/result/processors/exclusion_presets.go

@@ -54,7 +54,7 @@ var LinterExclusionPresets = map[string][]config.ExcludeRule{
 		{
 			// Almost all programs ignore errors on these functions and in most cases it's ok.
 			BaseRule: config.BaseRule{
-				Text: "Error return value of .((os\\.)?std(out|err)\\..*|.*Close" +
+				Text: "(?i)Error return value of .((os\\.)?std(out|err)\\..*|.*Close" +
 					"|.*Flush|os\\.Remove(All)?|.*print(f|ln)?|os\\.(Un)?Setenv). is not checked",
 				Linters:           []string{"errcheck"},
 				InternalReference: "EXC0001",