Skip to content

Commit 8cefc9d

Browse files
committed
review
1 parent a7e11f8 commit 8cefc9d

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

Diff for: pkg/commands/internal/migrate/migrate_linters_exclusions.go

+8-10
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ func addPrefix(old versionone.Issues, s *string) *string {
106106
}
107107

108108
func linterTestExclusions(old versionone.LintersSettings) []versiontwo.ExcludeRule {
109-
var results []versiontwo.ExcludeRule
110-
111109
var excludedTestLinters []string
112110

113111
if ptr.Deref(old.Asasalint.IgnoreTest) {
@@ -123,16 +121,16 @@ func linterTestExclusions(old versionone.LintersSettings) []versiontwo.ExcludeRu
123121
excludedTestLinters = append(excludedTestLinters, "gosmopolitan")
124122
}
125123

126-
if len(excludedTestLinters) > 0 {
127-
results = append(results, versiontwo.ExcludeRule{
128-
BaseRule: versiontwo.BaseRule{
129-
Linters: excludedTestLinters,
130-
Path: ptr.Pointer(`(.+)_test\.go`),
131-
},
132-
})
124+
if len(excludedTestLinters) <= 0 {
125+
return nil
133126
}
134127

135-
return results
128+
return []versiontwo.ExcludeRule{{
129+
BaseRule: versiontwo.BaseRule{
130+
Linters: excludedTestLinters,
131+
Path: ptr.Pointer(`(.+)_test\.go`),
132+
},
133+
}}
136134
}
137135

138136
func toExclusionPaths(old versionone.Issues) []string {

0 commit comments

Comments
 (0)