fix: make versioning inside Docker image consistent with binaries (#4279)

Co-authored-by: Fernandez Ludovic <[email protected]>

Author: alebcay

Diff for: build/Dockerfile

@@ -7,7 +7,9 @@ ARG DATE
 
 COPY / /golangci
 WORKDIR /golangci
-RUN CGO_ENABLED=0 go build -trimpath -ldflags "-s -w -X main.version=$VERSION -X main.commit=$SHORT_COMMIT -X main.date=$DATE" -o golangci-lint ./cmd/golangci-lint/main.go
+RUN APP_VERSION=${VERSION#v} \
+    CGO_ENABLED=0 \
+    go build -trimpath -ldflags "-s -w -X main.version=$APP_VERSION -X main.commit=$SHORT_COMMIT -X main.date=$DATE" -o golangci-lint ./cmd/golangci-lint/main.go
 
 # stage 2
 FROM golang:1.21

Diff for: build/alpine.Dockerfile

@@ -12,7 +12,9 @@ WORKDIR /golangci
 # git and mercurial are needed most times for go get`, etc.
 # See https://github.com/docker-library/golang/issues/80
 RUN apk --no-cache add gcc musl-dev git mercurial
-RUN CGO_ENABLED=0 go build -trimpath -ldflags "-s -w -X main.version=$VERSION -X main.commit=$SHORT_COMMIT -X main.date=$DATE" -o golangci-lint ./cmd/golangci-lint/main.go
+RUN APP_VERSION=${VERSION#v} \
+    CGO_ENABLED=0 \
+    go build -trimpath -ldflags "-s -w -X main.version=$APP_VERSION -X main.commit=$SHORT_COMMIT -X main.date=$DATE" -o golangci-lint ./cmd/golangci-lint/main.go
 
 # stage 2
 FROM golang:1.21-alpine