chore: remove v1 exclusion configuration

Author: ldez

Diff for: .golangci.next.reference.yml

@@ -261,6 +261,78 @@ linters:
   # Default: false
   fast: true
 
+  # Defines a set of rules to ignore issues.
+  # It does not skip the analysis, and so don't ignore "typecheck" errors.
+  exclusions:
+    # Mode of the generated files analysis.
+    #
+    # - `strict`: sources are excluded by following strictly the Go generated file convention.
+    #    Source files that have lines matching only the following regular expression will be excluded: `^// Code generated .* DO NOT EDIT\.$`
+    #    This line must appear before the first non-comment, non-blank text in the file.
+    #    https://go.dev/s/generatedcode
+    # - `lax`: sources are excluded if they contain lines `autogenerated file`, `code generated`, `do not edit`, etc.
+    # - `disable`: disable the generated files exclusion.
+    #
+    # Default: lax
+    generated: strict
+    # Log a warning if an exclusion rule is unused.
+    # Default: false
+    warn-unused: true
+    # Predefined exclusion rules.
+    # Default: []
+    presets:
+      - comments
+      - stdErrorHandling
+      - commonFalsePositives
+      - legacy
+
+    # Excluding configuration per-path, per-linter, per-text and per-source.
+    rules:
+      # Exclude some linters from running on tests files.
+      - path: _test\.go
+        linters:
+          - gocyclo
+          - errcheck
+          - dupl
+          - gosec
+
+      # Run some linter only for test files by excluding its issues for everything else.
+      - path-except: _test\.go
+        linters:
+          - forbidigo
+
+      # Exclude known linters from partially hard-vendored code,
+      # which is impossible to exclude via `nolint` comments.
+      # `/` will be replaced by current OS file path separator to properly work on Windows.
+      - path: internal/hmac/
+        text: "weak cryptographic primitive"
+        linters:
+          - gosec
+
+      # Exclude some `staticcheck` messages.
+      - linters:
+          - staticcheck
+        text: "SA9003:"
+
+      # Exclude `lll` issues for long lines with `go:generate`.
+      - linters:
+          - lll
+        source: "^//go:generate "
+
+    # Which file paths to exclude: they will be analyzed, but issues from them won't be reported.
+    # There is no need to include all autogenerated files,
+    # we confidently recognize autogenerated files.
+    # If it's not, please let us know.
+    # "/" will be replaced by current OS file path separator to properly work on Windows.
+    # Default: []
+    paths:
+      - ".*\\.my\\.go$"
+      - lib/bad.go
+    # Which file paths to not exclude.
+    # Default: []
+    paths-except:
+      - ".*\\.my\\.go$"
+      - lib/bad.go
 
 formatters:
   # Enable specific formatter.
@@ -3940,116 +4012,6 @@ linters-settings:
 
 
 issues:
-  # List of regexps of issue texts to exclude.
-  #
-  # But independently of this option we use default exclude patterns,
-  # it can be disabled by `exclude-use-default: false`.
-  # To list all excluded by default patterns execute `golangci-lint run --help`
-  #
-  # Default: https://golangci-lint.run/usage/false-positives/#default-exclusions
-  exclude:
-    - abcdef
-
-  # Excluding configuration per-path, per-linter, per-text and per-source
-  exclude-rules:
-    # Exclude some linters from running on tests files.
-    - path: _test\.go
-      linters:
-        - gocyclo
-        - errcheck
-        - dupl
-        - gosec
-
-    # Run some linter only for test files by excluding its issues for everything else.
-    - path-except: _test\.go
-      linters:
-        - forbidigo
-
-    # Exclude known linters from partially hard-vendored code,
-    # which is impossible to exclude via `nolint` comments.
-    # `/` will be replaced by current OS file path separator to properly work on Windows.
-    - path: internal/hmac/
-      text: "weak cryptographic primitive"
-      linters:
-        - gosec
-
-    # Exclude some `staticcheck` messages.
-    - linters:
-        - staticcheck
-      text: "SA9003:"
-
-    # Exclude `lll` issues for long lines with `go:generate`.
-    - linters:
-        - lll
-      source: "^//go:generate "
-
-  # Independently of option `exclude` we use default exclude patterns,
-  # it can be disabled by this option.
-  # To list all excluded by default patterns execute `golangci-lint run --help`.
-  # Default: true
-  exclude-use-default: false
-
-  # If set to true, `exclude` and `exclude-rules` regular expressions become case-sensitive.
-  # Default: false
-  exclude-case-sensitive: false
-
-  # Which dirs to exclude: issues from them won't be reported.
-  # Can use regexp here: `generated.*`, regexp is applied on full path,
-  # including the path prefix if one is set.
-  # Default dirs are skipped independently of this option's value (see exclude-dirs-use-default).
-  # "/" will be replaced by current OS file path separator to properly work on Windows.
-  # Default: []
-  exclude-dirs:
-    - src/external_libs
-    - autogenerated_by_my_lib
-
-  # Enables exclude of directories:
-  # - vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  # Default: true
-  exclude-dirs-use-default: false
-
-  # Which files to exclude: they will be analyzed, but issues from them won't be reported.
-  # There is no need to include all autogenerated files,
-  # we confidently recognize autogenerated files.
-  # If it's not, please let us know.
-  # "/" will be replaced by current OS file path separator to properly work on Windows.
-  # Default: []
-  exclude-files:
-    - ".*\\.my\\.go$"
-    - lib/bad.go
-
-  # Mode of the generated files analysis.
-  #
-  # - `strict`: sources are excluded by following strictly the Go generated file convention.
-  #    Source files that have lines matching only the following regular expression will be excluded: `^// Code generated .* DO NOT EDIT\.$`
-  #    This line must appear before the first non-comment, non-blank text in the file.
-  #    https://go.dev/s/generatedcode
-  # - `lax`: sources are excluded if they contain lines `autogenerated file`, `code generated`, `do not edit`, etc.
-  # - `disable`: disable the generated files exclusion.
-  #
-  # Default: lax
-  exclude-generated: strict
-
-  # The list of ids of default excludes to include or disable.
-  # https://golangci-lint.run/usage/false-positives/#default-exclusions
-  # Default: []
-  include:
-    - EXC0001
-    - EXC0002
-    - EXC0003
-    - EXC0004
-    - EXC0005
-    - EXC0006
-    - EXC0007
-    - EXC0008
-    - EXC0009
-    - EXC0010
-    - EXC0011
-    - EXC0012
-    - EXC0013
-    - EXC0014
-    - EXC0015
-
   # Maximum issues count per one linter.
   # Set to 0 to disable.
   # Default: 50

Diff for: jsonschema/golangci.next.jsonschema.json

@@ -4254,7 +4254,7 @@
           "properties": {
             "generated": {
               "enum": ["strict", "lax", "disable"],
-              "default": "lax"
+              "default": "strict"
             },
             "warn-unused": {
               "type": "boolean",
@@ -4374,107 +4374,6 @@
       "type": "object",
       "additionalProperties": false,
       "properties": {
-        "exclude": {
-          "description": "List of regular expressions of issue texts to exclude.\nBut independently from this option we use default exclude patterns. Their usage can be controlled through `exclude-use-default`.",
-          "type": "array",
-          "items": {
-            "type": "string"
-          }
-        },
-        "exclude-rules": {
-          "description": "Exclude configuration per-path, per-linter, per-text and per-source",
-          "type": "array",
-          "items": {
-            "type": "object",
-            "additionalProperties": false,
-            "properties": {
-              "path": {
-                "type": "string"
-              },
-              "path-except": {
-                "type": "string"
-              },
-              "linters": {
-                "type": "array",
-                "items": {
-                  "$ref": "#/definitions/linter-names"
-                }
-              },
-              "text": {
-                "type": "string"
-              },
-              "source": {
-                "type": "string"
-              }
-            }
-          }
-        },
-        "exclude-use-default": {
-          "description": "Independently from option `exclude` we use default exclude patterns. This behavior can be disabled by this option.",
-          "type": "boolean",
-          "default": true
-        },
-        "exclude-case-sensitive": {
-          "description": "If set to true, exclude and exclude-rules regular expressions become case sensitive.",
-          "type": "boolean",
-          "default": false
-        },
-        "exclude-generated": {
-          "description": "Mode of the generated files analysis.",
-          "enum": ["lax", "strict", "disable"],
-          "default": "lax"
-        },
-        "exclude-dirs": {
-          "description": "Which directories to exclude: issues from them won't be reported.",
-          "type": "array",
-          "items": {
-            "description": "You can use regexp here. The regexp is applied on the full path.\n\"/\" will be replaced by current OS file path separator to properly work on Windows.",
-            "type": "string",
-            "examples": ["generated.*"]
-          },
-          "default": [],
-          "examples": [["src/external_libs", "autogenerated_by_my_lib"]]
-        },
-        "exclude-dirs-use-default": {
-          "description": "Enable exclusion of directories \"vendor\", \"third_party\", \"testdata\", \"examples\", \"Godeps\", and \"builtin\".",
-          "type": "boolean",
-          "default": true
-        },
-        "exclude-files": {
-          "description": "Which files to exclude: they will be analyzed, but issues from them will not be reported.",
-          "type": "array",
-          "items": {
-            "description": "You can use regexp here. There is no need to include all autogenerated files, we confidently recognize them. If that is not the case, please let us know.\n\"/\" will be replaced by current OS file path separator to properly work on Windows.",
-            "type": "string",
-            "examples": [".*\\.my\\.go$"]
-          },
-          "default": [],
-          "examples": [[".*\\.my\\.go$", "lib/bad.go"]]
-        },
-        "include": {
-          "description": "The list of ids of default excludes to include or disable.",
-          "type": "array",
-          "items": {
-            "enum": [
-              "EXC0001",
-              "EXC0002",
-              "EXC0003",
-              "EXC0004",
-              "EXC0005",
-              "EXC0006",
-              "EXC0007",
-              "EXC0008",
-              "EXC0009",
-              "EXC0010",
-              "EXC0011",
-              "EXC0012",
-              "EXC0013",
-              "EXC0014",
-              "EXC0015"
-            ]
-          },
-          "default": []
-        },
         "max-issues-per-linter": {
           "description": "Maximum issues count per one linter. Set to 0 to disable.",
           "type": "integer",

Diff for: pkg/commands/flagsets.go

@@ -9,10 +9,8 @@ import (
 	"github.com/spf13/viper"
 
 	"github.com/golangci/golangci-lint/pkg/commands/internal"
-	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/lint/lintersdb"
-	"github.com/golangci/golangci-lint/pkg/result/processors"
 )
 
 const defaultMaxIssuesPerLinter = 50
@@ -130,27 +128,13 @@ func setupOutputFormatsFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
 
 //nolint:gomnd // magic numbers here is ok
 func setupIssuesFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
-	internal.AddHackedStringSliceP(fs, "exclude", "e", color.GreenString("Exclude issue by regexp"))
-	internal.AddFlagAndBind(v, fs, fs.Bool, "exclude-use-default", "issues.exclude-use-default", true,
-		getDefaultIssueExcludeHelp())
-	internal.AddFlagAndBind(v, fs, fs.Bool, "exclude-case-sensitive", "issues.exclude-case-sensitive", false,
-		color.GreenString("If set to true exclude and exclude rules regular expressions are case-sensitive"))
-
 	internal.AddFlagAndBind(v, fs, fs.Int, "max-issues-per-linter", "issues.max-issues-per-linter", defaultMaxIssuesPerLinter,
 		color.GreenString("Maximum issues count per one linter. Set to 0 to disable"))
 	internal.AddFlagAndBind(v, fs, fs.Int, "max-same-issues", "issues.max-same-issues", 3,
 		color.GreenString("Maximum count of issues with the same text. Set to 0 to disable"))
 	internal.AddFlagAndBind(v, fs, fs.Bool, "uniq-by-line", "issues.uniq-by-line", true,
 		color.GreenString("Make issues output unique by line"))
 
-	internal.AddHackedStringSlice(fs, "exclude-files", color.GreenString("Regexps of files to exclude"))
-	internal.AddHackedStringSlice(fs, "exclude-dirs", color.GreenString("Regexps of directories to exclude"))
-	internal.AddFlagAndBind(v, fs, fs.Bool, "exclude-dirs-use-default", "issues.exclude-dirs-use-default", true,
-		formatList("Use or not use default excluded directories:", processors.StdExcludeDirRegexps))
-
-	internal.AddFlagAndBind(v, fs, fs.String, "exclude-generated", "issues.exclude-generated", config.GeneratedModeLax,
-		color.GreenString("Mode of the generated files analysis"))
-
 	const newDesc = "Show only new issues: if there are unstaged changes or untracked files, only those changes " +
 		"are analyzed, else only changes in HEAD~ are analyzed.\nIt's a super-useful option for integration " +
 		"of golangci-lint into existing large codebase.\nIt's not practical to fix all existing issues at " +
@@ -186,16 +170,3 @@ func formatList(head string, items []string, foot ...string) string {
 
 	return strings.Join(parts, "\n")
 }
-
-func getDefaultIssueExcludeHelp() string {
-	parts := []string{color.GreenString("Use or not use default excludes:")}
-
-	for _, ep := range config.DefaultExcludePatterns {
-		parts = append(parts,
-			fmt.Sprintf("  - %s (%s): %s", color.BlueString(ep.ID), color.CyanString(ep.Linter), ep.Why),
-			fmt.Sprintf(`    Pattern: %s`, color.YellowString(`'`+ep.Pattern+`'`)),
-		)
-	}
-
-	return strings.Join(parts, "\n")
-}