Skip to content

Commit d35e0d4

Browse files
ldezldez
committed
fix: exclude-use-default is true by default
1 parent 8883832 commit d35e0d4

File tree

155 files changed

+348
-5
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

155 files changed

+348
-5
lines changed

Diff for: ‎pkg/commands/internal/migrate/migrate_formatters.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ func toFormatters(old *versionone.Config) versiontwo.Formatters {
1515
var paths []string
1616
if len(enable) > 0 {
1717
paths = slices.Concat(old.Issues.ExcludeFiles, old.Issues.ExcludeDirs)
18+
}
1819

19-
if old.Issues.UseDefaultExcludeDirs == nil || ptr.Deref(old.Issues.UseDefaultExcludeDirs) {
20-
paths = append(paths, "examples$")
21-
}
20+
if old.Issues.UseDefaultExcludeDirs == nil || ptr.Deref(old.Issues.UseDefaultExcludeDirs) {
21+
paths = append(paths, "examples$")
2222
}
2323

2424
paths = append(paths, toFormattersPathsFromRules(old.Issues)...)

Diff for: ‎pkg/commands/internal/migrate/migrate_linters_exclusions.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func toExclusionGenerated(excludeGenerated *string) *string {
3232
}
3333

3434
func toPresets(old versionone.Issues) []string {
35-
if !ptr.Deref(old.UseDefaultExcludes) {
35+
if old.UseDefaultExcludes != nil && !ptr.Deref(old.UseDefaultExcludes) {
3636
return nil
3737
}
3838

Diff for: ‎pkg/commands/internal/migrate/testdata/json/empty.golden.json

+10-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
{
22
"formatters": {
33
"exclusions": {
4-
"generated": "lax"
4+
"generated": "lax",
5+
"paths": [
6+
"examples$"
7+
]
58
}
69
},
710
"linters": {
@@ -11,6 +14,12 @@
1114
"third_party$",
1215
"builtin$",
1316
"examples$"
17+
],
18+
"presets": [
19+
"comments",
20+
"common-false-positives",
21+
"legacy",
22+
"std-error-handling"
1423
]
1524
}
1625
},

Diff for: ‎pkg/commands/internal/migrate/testdata/toml/empty.golden.toml

+9
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ version = '2'
33
[linters]
44
[linters.exclusions]
55
generated = 'lax'
6+
presets = [
7+
'comments',
8+
'common-false-positives',
9+
'legacy',
10+
'std-error-handling'
11+
]
612
paths = [
713
'third_party$',
814
'builtin$',
@@ -12,3 +18,6 @@ paths = [
1218
[formatters]
1319
[formatters.exclusions]
1420
generated = 'lax'
21+
paths = [
22+
'examples$'
23+
]

Diff for: ‎pkg/commands/internal/migrate/testdata/toml/linters-settings_goheader.toml

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
[issues]
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default = false
4+
# Only to not generate unrelated elements inside golden.
25
exclude-generated = "strict"
6+
# Only to not generate unrelated elements inside golden.
37
exclude-dirs-use-default = false
48

59
[linters-settings]

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/empty.golden.yml

+7
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,17 @@ version: "2"
22
linters:
33
exclusions:
44
generated: lax
5+
presets:
6+
- comments
7+
- common-false-positives
8+
- legacy
9+
- std-error-handling
510
paths:
611
- third_party$
712
- builtin$
813
- examples$
914
formatters:
1015
exclusions:
1116
generated: lax
17+
paths:
18+
- examples$

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_01_a.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_01_b.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_02_a.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_02_b.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_04_a.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_04_b.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_05_a.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-dirs-use-default: false
46

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_05_b.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-dirs-use-default: false
46

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_05_c.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-dirs-use-default: false
46

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_06_h.golden.yml

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
version: "2"
2+
linters:
3+
exclusions:
4+
presets:
5+
- comments
6+
- common-false-positives
7+
- legacy
8+
- std-error-handling

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_06_h.yml

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-generated: strict
4+
# Only to not generate unrelated elements inside golden.
5+
exclude-dirs-use-default: false

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_07_a.golden.yml

+4
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,7 @@ linters:
55
- third_party$
66
- builtin$
77
- examples$
8+
formatters:
9+
exclusions:
10+
paths:
11+
- examples$

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_07_a.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_07_b.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_08_a.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_08_b.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_09_a.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_09_b.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/issues_10.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_asasalint.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_bidichk.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_copyloopvar.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_custom.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_cyclop.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_decorder.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_depguard.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_dogsled.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_dupl.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_dupword.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_errcheck.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_errchkjson.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_errorlint.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_exhaustive.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_exhaustruct.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_fatcontext.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_forbidigo.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_funlen.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_gci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_ginkgolinter.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_gochecksumtype.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_gocognit.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_goconst.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

Diff for: ‎pkg/commands/internal/migrate/testdata/yaml/linters-settings_gocritic.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
issues:
2+
# Only to not generate unrelated elements inside golden.
3+
exclude-use-default: false
24
# Only to not generate unrelated elements inside golden.
35
exclude-generated: strict
46
# Only to not generate unrelated elements inside golden.

0 commit comments

Comments
 (0)