tests: update global tests

Author: ldez

Diff for: test/run_test.go

@@ -14,8 +14,18 @@ import (
 const minimalPkg = "minimalpkg"
 
 func TestAutogeneratedNoIssues(t *testing.T) {
+	binPath := testshared.InstallGolangciLint(t)
+
+	cfg := `
+				linters:
+					exclusions:
+						generated: lax
+			`
+
 	testshared.NewRunnerBuilder(t).
+		WithConfig(cfg).
 		WithTargetPath(testdataDir, "autogenerated").
+		WithBinPath(binPath).
 		Runner().
 		Install().
 		Run().
@@ -270,7 +280,6 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
 			desc: "lite loading",
 			args: []string{
 				"--output.text.print-issued-lines=false",
-				"--exclude-use-default=false",
 				"-Erevive",
 			},
 			target: "quicktemplate",
@@ -285,7 +294,6 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
 			desc: "full loading",
 			args: []string{
 				"--output.text.print-issued-lines=false",
-				"--exclude-use-default=false",
 				"-Erevive,govet",
 			},
 			target: "quicktemplate",
@@ -316,12 +324,21 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
 }
 
 func TestUnsafeOk(t *testing.T) {
+	binPath := testshared.InstallGolangciLint(t)
+
+	cfg := `
+				linters:
+					exclusions:
+						presets:
+						- commonFalsePositives
+			`
+
 	testshared.NewRunnerBuilder(t).
-		WithNoConfig().
+		WithConfig(cfg).
 		WithArgs("--enable-all").
 		WithTargetPath(testdataDir, "unsafe").
+		WithBinPath(binPath).
 		Runner().
-		Install().
 		Run().
 		ExpectNoIssues()
 }
@@ -361,39 +378,6 @@ func TestSortedResults(t *testing.T) {
 	}
 }
 
-func TestSkippedDirsNoMatchArg(t *testing.T) {
-	dir := filepath.Join(testdataDir, "skipdirs", "skip_me", "nested")
-
-	testshared.NewRunnerBuilder(t).
-		WithNoConfig().
-		WithArgs(
-			"--output.text.print-issued-lines=false",
-			"--exclude-dirs", dir,
-			"-Erevive",
-		).
-		WithTargetPath(dir).
-		Runner().
-		Install().
-		Run().
-		ExpectExitCode(exitcodes.IssuesFound).
-		ExpectOutputEq("testdata/skipdirs/skip_me/nested/with_issue.go:8:9: " +
-			"indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)\n")
-}
-
-func TestSkippedDirsTestdata(t *testing.T) {
-	testshared.NewRunnerBuilder(t).
-		WithNoConfig().
-		WithArgs(
-			"--output.text.print-issued-lines=false",
-			"-Erevive",
-		).
-		WithTargetPath(testdataDir, "skipdirs", "...").
-		Runner().
-		Install().
-		Run().
-		ExpectNoIssues() // all was skipped because in testdata
-}
-
 func TestIdentifierUsedOnlyInTests(t *testing.T) {
 	testshared.NewRunnerBuilder(t).
 		WithNoConfig().

Diff for: test/testdata/cgo/main.go

@@ -1,3 +1,4 @@
+// Package cgoexample ...
 package cgoexample
 
 /*
@@ -14,6 +15,7 @@ import (
 	"unsafe"
 )
 
+// Example ...
 func Example() {
 	cs := C.CString("Hello from stdio\n")
 	C.myprint(cs)

Diff for: test/testdata/configs/default_exclude.yml

@@ -1,5 +1,8 @@
 version: "2"
 
-issues:
-  include:
-    - EXC0011 # include issues about comments from `stylecheck`
+linters:
+  exclusions:
+    presets:
+      - stdErrorHandling
+      - commonFalsePositives
+      - legacy

Diff for: test/testdata/configs/path-except.yml

@@ -6,10 +6,11 @@ linters-settings:
       - fmt\.Print.*
       - time.Sleep(# no sleeping!)?
 
-issues:
-  exclude-rules:
-    # Apply forbidigo only to test files, exclude
-    # it everywhere else.
-    - path-except: _test\.go
-      linters:
-        - forbidigo
+linters:
+  exclusions:
+    rules:
+      # Apply forbidigo only to test files, exclude
+      # it everywhere else.
+      - path-except: _test\.go
+        linters:
+          - forbidigo

Diff for: test/testdata/default_exclude.go

@@ -4,18 +4,18 @@
 /*Package testdata ...*/
 package testdata
 
-// InvalidFuncComment, both revive and stylecheck will complain about this, // want stylecheck:`ST1020: comment on exported function ExportedFunc1 should be of the form "ExportedFunc1 ..."`
+// InvalidFuncComment, both revive and stylecheck will complain about this, // want `exported: comment on exported function ExportedFunc1 should be of the form "ExportedFunc1 ..."`
 // if include EXC0011, only the warning from revive will be ignored.
 // And only the warning from stylecheck will start with "ST1020".
 func ExportedFunc1() {
 }
 
-// InvalidFuncComment // want stylecheck:`ST1020: comment on exported function ExportedFunc2 should be of the form "ExportedFunc2 ..."`
+// InvalidFuncComment // want `ST1020: comment on exported function ExportedFunc2 should be of the form "ExportedFunc2 ..."`
 //
 //nolint:revive
 func ExportedFunc2() {
 }
 
 //nolint:stylecheck
-func IgnoreAll() {
+func IgnoreAll() { // want "exported: exported function IgnoreAll should have comment or be unexported"
 }

Diff for: test/testdata/skipdirs/examples/with_issue.go

@@ -1,10 +1,12 @@
+// Package pkg ...
 package pkg
 
 import (
 	"log"
 	"unsafe"
 )
 
+// F ...
 func F() {
 	x := 123 // of type int
 	p := unsafe.Pointer(&x)