feat: allow to disable typecheck on internal tests

Author: ldez

pkg/lint/lintersdb/enabled_set.go

@@ -31,6 +31,7 @@ func NewEnabledSet(m *Manager, v *Validator, log logutils.Log, cfg *config.Confi
 	}
 }
 
+//nolint:gocyclo // the complexity cannot be reduced.
 func (es EnabledSet) build(lcfg *config.Linters, enabledByDefaultLinters []*linter.Config) map[string]*linter.Config {
 	es.debugf("Linters config: %#v", lcfg)
 
@@ -80,7 +81,7 @@ func (es EnabledSet) build(lcfg *config.Linters, enabledByDefaultLinters []*lint
 	}
 
 	// typecheck is not a real linter and cannot be disabled.
-	if _, ok := resultLintersSet["typecheck"]; !ok {
+	if _, ok := resultLintersSet["typecheck"]; !ok && !es.cfg.InternalCmdTest {
 		for _, lc := range es.m.GetLinterConfigs("typecheck") {
 			// it's important to use lc.Name() nor name because name can be alias
 			resultLintersSet[lc.Name()] = lc

test/run_test.go

@@ -243,7 +243,7 @@ func TestLineDirective(t *testing.T) {
 			},
 			configPath: "testdata/linedirective/gomodguard.yml",
 			targetPath: "linedirective",
-			expected: "import of package `github.com/ryancurrah/gomodguard` is blocked because the module is not " +
+			expected: "import of package `golang.org/x/tools/go/analysis` is blocked because the module is not " +
 				"in the allowed modules list. (gomodguard)",
 		},
 		{

test/testdata/linedirective/gomodguard.yml

@@ -2,4 +2,4 @@ linters-settings:
   gomodguard:
     allowed:
       domains:
-        - golang.org
+        - github.com

test/testdata/linedirective/hello.go

@@ -3,7 +3,7 @@
 package main
 
 import (
-	"github.com/ryancurrah/gomodguard"
+	"golang.org/x/tools/go/analysis"
 )
 
 func _() {
@@ -26,6 +26,10 @@ func b() {
 	fmt.Println("foo")
 }
 
+func c(){
+	_ = analysis.Analyzer{}
+}
+
 func wsl() bool {
 
 	return true