Allow //nolint only with specific linter and check set and wo space

[jirfag]

Breaking change for v2. We can require not only specific linter (staticcheck), but also a specific check inside it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[JoelSpeed]

Why would this be/does this have to be a breaking change? I came to this from looking at #2706.

The suggested format within that issue was to extend the format of the existing nolint directive

// nolint:staticcheck # Ignore all staticcheck issues

// nolint:staticcheck:subrule # Ignore only the checks generated by the subrule

I don't see how that would be breaking?

There didn't appear to be much discussion on the duplicate issue as to whether some format like this was appropriate, so I'm wondering if we could revive the idea here, what do maintainers feel about extending the existing nolint in a non-breaking way?

I suppose a key to implementing this could be how we understand which rule within a linter triggered an issue, I guess there's no standard format for that right now, and if we start enforcing a format, then perhaps that could be a breaking change for some linters?

[ldez]

This issue has been around for 5 years, golangci-lint has changed since the issue was opened.

nolint directives will be replaced by another directive approach.

[JoelSpeed]

Are there details of the new approach? A tracking issue?

[ldez]

#2706 (comment)
#1658