Skip to content

Multi-line output of gochecknoglobals description in golangci-lint linters is confusing in non-color environments #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
bconway opened this issue Dec 29, 2020 · 2 comments · Fixed by #1663
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@bconway
Copy link

bconway commented Dec 29, 2020

Thank you for creating the issue!

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).

Please include the following information:

Version of golangci-lint
$ golangci-lint --version
golangci-lint has version v1.34.1 built from (unknown, mod sum: "h1:xf1yVlLBNeCIoOHWXhwqnUeaqzONllRSgiLSahNt0Mw=") on (unknown)
Config file
$ cat .golangci.yml
cat: .golangci.yml: No such file or directory
Go environment
$ go version
go version go1.15.6 darwin/amd64

This is not a new issue, but I keep forgetting to report it. Of all the linters in golangci-lint linters, gochecknoglobals is the only one that has a multi-line output, and it also includes multiple blank newlines. In non-colorized output, based on terminal or piping to less without colorization, this is confusing and looks like a new section:

Screen Shot 2020-12-29 at 9 02 48 AM

Perhaps cutting the description down to a single sentence to match the other linters would make things more uniform?

Thanks.

@bconway bconway added the bug Something isn't working label Dec 29, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 29, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@bconway
Copy link
Author

bconway commented Feb 7, 2021

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant