Skip to content

Multiple Issues don't seem to play nice together. #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thebeline opened this issue Mar 26, 2021 · 3 comments
Closed

Multiple Issues don't seem to play nice together. #1874

thebeline opened this issue Mar 26, 2021 · 3 comments
Labels
question Further information is requested

Comments

@thebeline
Copy link

I have one file where the push makes one line super long, and adds weird whitespace somewhere else.

I get a gofumpt error on the whitespace (first), and then on the long line (what I am referring to from here forward) I get another gofumpt error.

If I disable gofumpt, it (super weird) turns into a goimports error (but still on that long line), even though I have enabled only-new-issues: true and didn't touch the import section at all.

Then... If I turn on --fix (which the Action can't do), with gofumpt back on, I get a slew of info things (in the log) and an lll error, finally...

I mean... A few issues here:

  • I don't understand how or why goimports is triggering when I didn't touch the imports. Except for maybe it was using something that was imported, but since only-new-issues: true is designed to keep the issues related to what the Push or PR actually changes, it seems weird.
  • If the system can annotate, it would be SWELL if it could group the annotations in some way, so you aren't patching and pushing just to chase ghosts. Having all of the detected issues right there would be ideal.
  • The descriptions (File is not gofumpt-ed with -extra (gofumpt)) REALLY could use some translation. I feel like there is enough data there to determine what the issue is in human readable terms.
@ldez ldez transferred this issue from golangci/golangci-lint-action Mar 27, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 27, 2021

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez added the duplicate This issue or pull request already exists label Mar 27, 2021
@ldez ldez marked this as a duplicate of #1490 Mar 27, 2021
@ldez ldez closed this as completed Mar 27, 2021
@ldez ldez marked this as not a duplicate of #1490 Mar 27, 2021
@ldez ldez added question Further information is requested and removed duplicate This issue or pull request already exists labels Mar 27, 2021
@ldez
Copy link
Member

ldez commented Mar 27, 2021

#1875

@thebeline
Copy link
Author

I am not entirely sure what was going on here, but it seems resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants