Skip to content

new-from-rev: Can't process result by diff processor: can't prepare diff by revgrep: could not read git repo: error executing git diff ...: exit status 129 #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 tasks done
pohly opened this issue Oct 24, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@pohly
Copy link
Contributor

pohly commented Oct 24, 2023

Welcome

Description of the problem

I am trying to update the version of golangci-lint used by Kubernetes from v1.54.1 to v1.55.0: kubernetes/kubernetes#121476

Invocations with --new --new-from-rev fail:

running env LOGCHECK_CONFIG=/home/prow/go/src/k8s.io/kubernetes/hack/logcheck.conf /home/prow/go/src/k8s.io/kubernetes/_output/local/bin/golangci-lint run --config=/home/prow/go/src/k8s.io/kubernetes/hack/golangci-strict.yaml --new --new-from-rev=f8a4e343a106a73145464e8de8a919d13b59d25a ./...
ERROR: level=warning msg="[runner] Can't process result by diff processor: can't prepare diff by revgrep: could not read git repo: error executing git diff \"f8a4e343a106a73145464e8de8a919d13b59d25a\" \"\": exit status 129" 
....
<errors in existing code>

The same invocation worked with v1.54.1.

Version of golangci-lint

$ golangci-lint --version
# Paste output here

Configuration

Go environment

Go 1.21.3

Verbose output of running

A minimal reproducible example or link to a public repository

Check out kubernetes/kubernetes#121476, run hack/verify-golangci-lint.sh -a -n:

$ hack/verify-golangci-lint.sh -a -n
go version go1.21.3 linux/amd64
installing golangci-lint and logcheck plugin from hack/tools into /nvme/gopath/src/k8s.io/kubernetes/_output/local/bin
running env LOGCHECK_CONFIG=/nvme/gopath/src/k8s.io/kubernetes/hack/logcheck.conf /nvme/gopath/src/k8s.io/kubernetes/_output/local/bin/golangci-lint run --config=/nvme/gopath/src/k8s.io/kubernetes/hack/golangci-hints.yaml --color=always --new --new-from-rev=015297a5776aa036c334c89740f89f74cb83190c ./...
ERROR: level=warning msg="[runner] Can't process result by diff processor: can't prepare diff by revgrep: could not read git repo: error executing git diff \"015297a5776aa036c334c89740f89f74cb83190c\" \"\": exit status 129"
...

Validation

  • Yes, I've included all information above (version, config, etc.).
@pohly pohly added the bug Something isn't working label Oct 24, 2023
@ldez
Copy link
Member

ldez commented Oct 24, 2023

Duplicate of #4152

@ldez ldez marked this as a duplicate of #4152 Oct 24, 2023
@ldez ldez closed this as completed Oct 24, 2023
@ldez ldez added duplicate This issue or pull request already exists and removed bug Something isn't working labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants