Skip to content

Commit 5cfdb52

Browse files
committed
Allow passing just an event and ID to turn off listener
Fixes #767
1 parent 8f3c569 commit 5cfdb52

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/howler.core.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,10 +1548,17 @@
15481548
var events = self['_on' + event];
15491549
var i = 0;
15501550

1551-
if (fn) {
1551+
// Allow passing just an event and ID.
1552+
if (typeof fn === 'number') {
1553+
id = fn;
1554+
fn = null;
1555+
}
1556+
1557+
if (fn || id) {
15521558
// Loop through event store and remove the passed function.
15531559
for (i=0; i<events.length; i++) {
1554-
if (fn === events[i].fn && id === events[i].id) {
1560+
var isId = (id === events[i].id);
1561+
if (fn === events[i].fn && isId || !fn && isId) {
15551562
events.splice(i, 1);
15561563
break;
15571564
}

0 commit comments

Comments
 (0)