Skip to content

Commit f601e09

Browse files
authored
Fix storage related roles for compute service account in cloud deploy release example (#19)
<!-- Thank you for proposing a pull request! Please note that SOME TESTS WILL LIKELY FAIL due to how GitHub exposes secrets in Pull Requests from forks. Someone from the team will review your Pull Request and respond. Please describe your change and any implementation details below. --> The roles listed in the instructions of cloud deploy to cloud run example are not working. They generate the following error: ``` 400: The role name must be in the form "roles/{role}", "organizations/{organization_id}/roles/{role}", or "projects/{project_id}/roles/{role}"., badRequest ``` I checked the roles on [the Storage IAM Roles page](https://cloud.google.com/storage/docs/access-control/iam-roles) and corrected them. Signed-off-by: Can Kutlu Kınay <[email protected]>
1 parent 11125bf commit f601e09

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

workflows/create-cloud-deploy-release/cloud-deploy-to-cloud-run.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
# roles/run.developer (To create Cloud Run services)
4646
#
4747
# Cloud Storage
48-
# storage/object.viewer (To read Cloud Deploy artifacts)
49-
# storage/object.creator (To write Cloud Deploy artifacts)
48+
# roles/storage.objectViewer (To read Cloud Deploy artifacts)
49+
# roles/storage.objectCreator (To write Cloud Deploy artifacts)
5050
#
5151
# Additionally, the default compute service account requires permissions to "ActAs" itself
5252
# to be able to deploy to Cloud Run. You can add this permission with the following command:

0 commit comments

Comments
 (0)