fix array index out of bounds

Author: h00810684

summary/percentiles.go

@@ -44,9 +44,17 @@ func (s Uint64Slice) GetPercentile(d float64) uint64 {
 		return 0
 	}
 	sort.Sort(s)
+	if d == 1 {
+		return s[count-1]
+	}
 	n := float64(d * (float64(count) + 1))
 	idx, frac := math.Modf(n)
 	index := int(idx)
+
+	if index < 1 {
+		index = 1
+	}
+
 	percentile := float64(s[index-1])
 	if index > 1 && index < count {
 		percentile += frac * float64(s[index]-s[index-1])

summary/percentiles_test.go

@@ -46,6 +46,14 @@ func TestPercentile(t *testing.T) {
 	assertPercentile(t, s, 0.2, 21)
 	assertPercentile(t, s, 0.7, 74)
 	assertPercentile(t, s, 0.9, 95)
+
+	// boundary value
+	assertPercentile(t, s[:5], 0.9, 5)
+	assertPercentile(t, s[:5], 1.1, 0)
+	assertPercentile(t, []uint64{}, 0, 0)
+	assertPercentile(t, s, 0, 1)
+	assertPercentile(t, s[:11], 1, 11)
+	assertPercentile(t, s, 1.0, 105)
 }
 
 func TestMean(t *testing.T) {