Leave less implicit dynamics

Used dart-archive/linter#262 to spot these

Author: Olivier Chafik

lib/reloader/reloader.dart

@@ -21,8 +21,9 @@ import 'dart:async';
 ///
 /// Note that calls to this function and imports of this file are
 /// removed by `scissors/reloader/transformer` in release mode.
-setupReloader(
-    {timestampBaseUrl: '/', delay: const Duration(seconds: 1)}) async {
+Future setupReloader(
+    {String timestampBaseUrl: '/',
+    Duration delay: const Duration(seconds: 1)}) async {
   var initialTimestamp = await _getTimestamp(timestampBaseUrl);
   await Future.doWhile(() async {
     await new Future.delayed(const Duration(seconds: 1));
@@ -39,7 +40,7 @@ setupReloader(
   });
 }
 
-Future<int> _getTimestamp(timestampBaseUrl) {
+Future<int> _getTimestamp(String timestampBaseUrl) {
   var completer = new Completer<int>();
   new HttpRequest()
     ..open('GET', timestampBaseUrl + 'timestamp')

lib/src/css_mirroring/entity.dart

@@ -53,7 +53,8 @@ int _getNodeStart(TreeNode node) {
   return node.span.start.offset;
 }
 
-int getDeclarationEnd(String source, List decls, int iDecl) {
+int getDeclarationEnd/*<T extends TreeNode>*/(
+    String source, List/*<T>*/ decls, int iDecl) {
   if (iDecl < decls.length - 1) {
     return decls[iDecl + 1].span.start.offset;
   }

lib/src/css_pruning/ng_class_parser.dart

@@ -83,4 +83,4 @@ NgClassParsingResults parseNgClassAttribute(String attributeValue) {
   return new NgClassParsingResults(hasVariableClasses, classes);
 }
 
-_trimmer(s) => s.trim();
+String _trimmer(String s) => s.trim();

lib/src/css_pruning/usage_collector.dart

@@ -55,7 +55,7 @@ class UsageCollector extends dom_parsing.TreeVisitor {
         desc.classFragments.add(pattern);
       }
     }
-    for (var name in node.attributes.keys) {
+    for (dynamic name in node.attributes.keys) {
       if (name is! String) continue;
 
       var m = _ng2ClassNameAttrRx.matchAsPrefix(name);

lib/src/image_inlining/main.dart

@@ -54,12 +54,12 @@ main(List<String> args) async {
     await stream.pipe(output.openWrite());
 }
 
-makeFileAsset(File file) {
+Asset makeFileAsset(File file) {
   var path = relative(file.path, from: Directory.current.path);
   return new Asset.fromFile(new AssetId(_package, path), new File(path));
 }
 
-makeStringAsset(String path, String input) {
+Asset makeStringAsset(String path, String input) {
   return new Asset.fromString(new AssetId(_package, path), input);
 }
 

lib/src/parts_check/transformer.dart

@@ -42,7 +42,8 @@ class PartsCheckTransformer extends Transformer
   bool isPrimary(AssetId id) =>
       expectedPartCounts.isNotEmpty && super.isPrimary(id);
 
-  get expectedPartCounts => _settings.expectedPartCounts.value;
+  Map<String, int> get expectedPartCounts =>
+      _settings.expectedPartCounts.value as Map<String, int>;
 
   @override
   apply(Transform transform) async {

lib/src/permutations/transformer.dart

@@ -103,15 +103,15 @@ class PermutationsTransformer extends AggregateTransformer
     var map = new IntlDeferredMap.fromJson(deferredMapJson);
 
     var defaultLocale = _settings.defaultLocale.value;
-    var allLocales = []..addAll(map.locales);
+    var allLocales = <String>[]..addAll(map.locales);
     if (defaultLocale != null) allLocales.add(defaultLocale);
 
     if (_settings.verbose.value) {
       transform.logger.info('Found entry points ${map.mainNames}, '
           'and locales ${map.locales} with default locale $defaultLocale');
     }
 
-    Asset getMatchingAsset(path, {throwIfNotFound: true}) =>
+    Asset getMatchingAsset(String path, {throwIfNotFound: true}) =>
         inputs.firstWhere((a) => a.id.path.endsWith(path), orElse: () {
           if (!throwIfNotFound) return null;
 

lib/src/utils/process_utils.dart

@@ -38,7 +38,7 @@ String which(String path) => successString('which $path', _which(path)).trim();
 
 bool hasExecutable(String name) => _which(name).exitCode == 0;
 
-Future<ProcessResult> pipeInAndOutOfNewProcess(Process p, input) async {
+Future<ProcessResult> pipeInAndOutOfNewProcess(Process p, dynamic input) async {
   if (input is String) {
     p.stdin.write(input);
   } else if (input is List<int>) {

lib/src/utils/setting.dart

@@ -44,7 +44,7 @@ class Setting<T> {
     if (value == null) {
       _value = isDebug ? debugDefault : releaseDefault;
     } else {
-      _value = parser != null ? parser(value) : value as T;
+      _value = parser != null ? parser('$value') : value as T;
     }
   }
 }

lib/src/utils/settings_base.dart

@@ -57,8 +57,10 @@ abstract class SettingsBase {
   static const _releaseConfigKey = 'release';
 
   SettingsBase(this._settings) {
-    var config = _settings.configuration;
-    config.addAll(config[isDebug ? _debugConfigKey : _releaseConfigKey] ?? {});
+    var config = _settings.configuration as Map<String, dynamic>;
+    config.addAll(config[isDebug ? _debugConfigKey : _releaseConfigKey]
+        as Map<String, dynamic> ??
+        const <String, dynamic>{});
 
     var settingList = getAllSettings();
     var validKeys = []