Skip to content

[linux/windows] Provide built in codecs (json, standard, etc.) inside the embedder library #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stuartmorgan-g opened this issue Feb 5, 2019 · 1 comment

Comments

@stuartmorgan-g
Copy link
Collaborator

The first pass of #230 moves all the code handling into the client wrapper, which means that each plugin needs a copy of the encoding. E.g., if a plugin uses the JSON codec, it has to not only build json_*_codec.cc, but statically link a copy of jsoncpp.

The wrapper library will probably continue to provide the generic templated codec code, for implementing custom codecs, but if possible implementations of the core codecs should be available in the shared library for ease of use. This would mean making a type hierarchy (as is needed for Standard*Codec already) that can be passed through an ABI-friendly API, so that objects can be constructed outside the library, passed in, and then converted to binary (which would need to be owned by the library and provide a deleter function).

@stuartmorgan-g
Copy link
Collaborator Author

Moved to flutter/flutter#30669

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant