Skip to content

Commit f7b63ba

Browse files
gmlewisgmlewis
committed
Change new([]*...) to slice zero value
This change is a proposal and is open for discussion. Also fixed a couple locations that were returning nil instead of returning the valid err. Change-Id: I62da2980c76d6220ce2ef12e6a1e64b60769ab01
1 parent cf19f97 commit f7b63ba

39 files changed

+236
-236
lines changed

‎github/activity_events.go

+24-24
Original file line numberDiff line numberDiff line change
@@ -110,13 +110,13 @@ func (s *ActivityService) ListEvents(opt *ListOptions) ([]*Event, *Response, err
110110
return nil, nil, err
111111
}
112112

113-
events := new([]*Event)
114-
resp, err := s.client.Do(req, events)
113+
var events []*Event
114+
resp, err := s.client.Do(req, &events)
115115
if err != nil {
116116
return nil, resp, err
117117
}
118118

119-
return *events, resp, err
119+
return events, resp, nil
120120
}
121121

122122
// ListRepositoryEvents lists events for a repository.
@@ -134,13 +134,13 @@ func (s *ActivityService) ListRepositoryEvents(owner, repo string, opt *ListOpti
134134
return nil, nil, err
135135
}
136136

137-
events := new([]*Event)
138-
resp, err := s.client.Do(req, events)
137+
var events []*Event
138+
resp, err := s.client.Do(req, &events)
139139
if err != nil {
140140
return nil, resp, err
141141
}
142142

143-
return *events, resp, err
143+
return events, resp, nil
144144
}
145145

146146
// ListIssueEventsForRepository lists issue events for a repository.
@@ -158,13 +158,13 @@ func (s *ActivityService) ListIssueEventsForRepository(owner, repo string, opt *
158158
return nil, nil, err
159159
}
160160

161-
events := new([]*IssueEvent)
162-
resp, err := s.client.Do(req, events)
161+
var events []*IssueEvent
162+
resp, err := s.client.Do(req, &events)
163163
if err != nil {
164164
return nil, resp, err
165165
}
166166

167-
return *events, resp, err
167+
return events, resp, nil
168168
}
169169

170170
// ListEventsForRepoNetwork lists public events for a network of repositories.
@@ -182,13 +182,13 @@ func (s *ActivityService) ListEventsForRepoNetwork(owner, repo string, opt *List
182182
return nil, nil, err
183183
}
184184

185-
events := new([]*Event)
186-
resp, err := s.client.Do(req, events)
185+
var events []*Event
186+
resp, err := s.client.Do(req, &events)
187187
if err != nil {
188188
return nil, resp, err
189189
}
190190

191-
return *events, resp, err
191+
return events, resp, nil
192192
}
193193

194194
// ListEventsForOrganization lists public events for an organization.
@@ -206,13 +206,13 @@ func (s *ActivityService) ListEventsForOrganization(org string, opt *ListOptions
206206
return nil, nil, err
207207
}
208208

209-
events := new([]*Event)
210-
resp, err := s.client.Do(req, events)
209+
var events []*Event
210+
resp, err := s.client.Do(req, &events)
211211
if err != nil {
212212
return nil, resp, err
213213
}
214214

215-
return *events, resp, err
215+
return events, resp, nil
216216
}
217217

218218
// ListEventsPerformedByUser lists the events performed by a user. If publicOnly is
@@ -236,13 +236,13 @@ func (s *ActivityService) ListEventsPerformedByUser(user string, publicOnly bool
236236
return nil, nil, err
237237
}
238238

239-
events := new([]*Event)
240-
resp, err := s.client.Do(req, events)
239+
var events []*Event
240+
resp, err := s.client.Do(req, &events)
241241
if err != nil {
242242
return nil, resp, err
243243
}
244244

245-
return *events, resp, err
245+
return events, resp, nil
246246
}
247247

248248
// ListEventsReceivedByUser lists the events received by a user. If publicOnly is
@@ -266,13 +266,13 @@ func (s *ActivityService) ListEventsReceivedByUser(user string, publicOnly bool,
266266
return nil, nil, err
267267
}
268268

269-
events := new([]*Event)
270-
resp, err := s.client.Do(req, events)
269+
var events []*Event
270+
resp, err := s.client.Do(req, &events)
271271
if err != nil {
272272
return nil, resp, err
273273
}
274274

275-
return *events, resp, err
275+
return events, resp, nil
276276
}
277277

278278
// ListUserEventsForOrganization provides the user’s organization dashboard. You
@@ -291,11 +291,11 @@ func (s *ActivityService) ListUserEventsForOrganization(org, user string, opt *L
291291
return nil, nil, err
292292
}
293293

294-
events := new([]*Event)
295-
resp, err := s.client.Do(req, events)
294+
var events []*Event
295+
resp, err := s.client.Do(req, &events)
296296
if err != nil {
297297
return nil, resp, err
298298
}
299299

300-
return *events, resp, err
300+
return events, resp, nil
301301
}

‎github/activity_star.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ func (s *ActivityService) ListStargazers(owner, repo string, opt *ListOptions) (
3737
// TODO: remove custom Accept header when this API fully launches
3838
req.Header.Set("Accept", mediaTypeStarringPreview)
3939

40-
stargazers := new([]*Stargazer)
41-
resp, err := s.client.Do(req, stargazers)
40+
var stargazers []*Stargazer
41+
resp, err := s.client.Do(req, &stargazers)
4242
if err != nil {
4343
return nil, resp, err
4444
}
4545

46-
return *stargazers, resp, err
46+
return stargazers, resp, nil
4747
}
4848

4949
// ActivityListStarredOptions specifies the optional parameters to the
@@ -84,13 +84,13 @@ func (s *ActivityService) ListStarred(user string, opt *ActivityListStarredOptio
8484
// TODO: remove custom Accept header when this API fully launches
8585
req.Header.Set("Accept", mediaTypeStarringPreview)
8686

87-
repos := new([]*StarredRepository)
88-
resp, err := s.client.Do(req, repos)
87+
var repos []*StarredRepository
88+
resp, err := s.client.Do(req, &repos)
8989
if err != nil {
9090
return nil, resp, err
9191
}
9292

93-
return *repos, resp, err
93+
return repos, resp, nil
9494
}
9595

9696
// IsStarred checks if a repository is starred by authenticated user.

‎github/activity_watching.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ func (s *ActivityService) ListWatchers(owner, repo string, opt *ListOptions) ([]
3737
return nil, nil, err
3838
}
3939

40-
watchers := new([]*User)
41-
resp, err := s.client.Do(req, watchers)
40+
var watchers []*User
41+
resp, err := s.client.Do(req, &watchers)
4242
if err != nil {
4343
return nil, resp, err
4444
}
4545

46-
return *watchers, resp, err
46+
return watchers, resp, nil
4747
}
4848

4949
// ListWatched lists the repositories the specified user is watching. Passing
@@ -67,13 +67,13 @@ func (s *ActivityService) ListWatched(user string, opt *ListOptions) ([]*Reposit
6767
return nil, nil, err
6868
}
6969

70-
watched := new([]*Repository)
71-
resp, err := s.client.Do(req, watched)
70+
var watched []*Repository
71+
resp, err := s.client.Do(req, &watched)
7272
if err != nil {
7373
return nil, resp, err
7474
}
7575

76-
return *watched, resp, err
76+
return watched, resp, nil
7777
}
7878

7979
// GetRepositorySubscription returns the subscription for the specified

‎github/authorizations.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,12 @@ func (s *AuthorizationsService) List(opt *ListOptions) ([]*Authorization, *Respo
146146
return nil, nil, err
147147
}
148148

149-
auths := new([]*Authorization)
150-
resp, err := s.client.Do(req, auths)
149+
var auths []*Authorization
150+
resp, err := s.client.Do(req, &auths)
151151
if err != nil {
152152
return nil, resp, err
153153
}
154-
return *auths, resp, err
154+
return auths, resp, nil
155155
}
156156

157157
// Get a single authorization.

‎github/gists.go

+15-15
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ func (s *GistsService) List(user string, opt *GistListOptions) ([]*Gist, *Respon
109109
return nil, nil, err
110110
}
111111

112-
gists := new([]*Gist)
113-
resp, err := s.client.Do(req, gists)
112+
var gists []*Gist
113+
resp, err := s.client.Do(req, &gists)
114114
if err != nil {
115115
return nil, resp, err
116116
}
117117

118-
return *gists, resp, err
118+
return gists, resp, nil
119119
}
120120

121121
// ListAll lists all public gists.
@@ -132,13 +132,13 @@ func (s *GistsService) ListAll(opt *GistListOptions) ([]*Gist, *Response, error)
132132
return nil, nil, err
133133
}
134134

135-
gists := new([]*Gist)
136-
resp, err := s.client.Do(req, gists)
135+
var gists []*Gist
136+
resp, err := s.client.Do(req, &gists)
137137
if err != nil {
138138
return nil, resp, err
139139
}
140140

141-
return *gists, resp, err
141+
return gists, resp, nil
142142
}
143143

144144
// ListStarred lists starred gists of authenticated user.
@@ -155,13 +155,13 @@ func (s *GistsService) ListStarred(opt *GistListOptions) ([]*Gist, *Response, er
155155
return nil, nil, err
156156
}
157157

158-
gists := new([]*Gist)
159-
resp, err := s.client.Do(req, gists)
158+
var gists []*Gist
159+
resp, err := s.client.Do(req, &gists)
160160
if err != nil {
161161
return nil, resp, err
162162
}
163163

164-
return *gists, resp, err
164+
return gists, resp, nil
165165
}
166166

167167
// Get a single gist.
@@ -246,13 +246,13 @@ func (s *GistsService) ListCommits(id string) ([]*GistCommit, *Response, error)
246246
return nil, nil, err
247247
}
248248

249-
gistCommits := new([]*GistCommit)
250-
resp, err := s.client.Do(req, gistCommits)
249+
var gistCommits []*GistCommit
250+
resp, err := s.client.Do(req, &gistCommits)
251251
if err != nil {
252252
return nil, resp, err
253253
}
254254

255-
return *gistCommits, resp, err
255+
return gistCommits, resp, nil
256256
}
257257

258258
// Delete a gist.
@@ -334,11 +334,11 @@ func (s *GistsService) ListForks(id string) ([]*GistFork, *Response, error) {
334334
return nil, nil, err
335335
}
336336

337-
gistForks := new([]*GistFork)
338-
resp, err := s.client.Do(req, gistForks)
337+
var gistForks []*GistFork
338+
resp, err := s.client.Do(req, &gistForks)
339339
if err != nil {
340340
return nil, resp, err
341341
}
342342

343-
return *gistForks, resp, err
343+
return gistForks, resp, nil
344344
}

‎github/gists_comments.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@ func (s *GistsService) ListComments(gistID string, opt *ListOptions) ([]*GistCom
3838
return nil, nil, err
3939
}
4040

41-
comments := new([]*GistComment)
42-
resp, err := s.client.Do(req, comments)
41+
var comments []*GistComment
42+
resp, err := s.client.Do(req, &comments)
4343
if err != nil {
4444
return nil, resp, err
4545
}
4646

47-
return *comments, resp, err
47+
return comments, resp, nil
4848
}
4949

5050
// GetComment retrieves a single comment from a gist.

‎github/gitignore.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ func (s GitignoresService) List() ([]string, *Response, error) {
3232
return nil, nil, err
3333
}
3434

35-
availableTemplates := new([]string)
36-
resp, err := s.client.Do(req, availableTemplates)
35+
var availableTemplates []string
36+
resp, err := s.client.Do(req, &availableTemplates)
3737
if err != nil {
3838
return nil, resp, err
3939
}
4040

41-
return *availableTemplates, resp, err
41+
return availableTemplates, resp, nil
4242
}
4343

4444
// Get a Gitignore by name.

‎github/integration.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ func (s *IntegrationsService) ListInstallations(opt *ListOptions) ([]*Installati
2828
// TODO: remove custom Accept header when this API fully launches.
2929
req.Header.Set("Accept", mediaTypeIntegrationPreview)
3030

31-
i := new([]*Installation)
31+
var i []*Installation
3232
resp, err := s.client.Do(req, &i)
3333
if err != nil {
3434
return nil, resp, err
3535
}
3636

37-
return *i, resp, err
37+
return i, resp, nil
3838
}

‎github/issues.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,13 @@ func (s *IssuesService) listIssues(u string, opt *IssueListOptions) ([]*Issue, *
141141
// TODO: remove custom Accept header when this API fully launches.
142142
req.Header.Set("Accept", mediaTypeReactionsPreview)
143143

144-
issues := new([]*Issue)
145-
resp, err := s.client.Do(req, issues)
144+
var issues []*Issue
145+
resp, err := s.client.Do(req, &issues)
146146
if err != nil {
147147
return nil, resp, err
148148
}
149149

150-
return *issues, resp, err
150+
return issues, resp, nil
151151
}
152152

153153
// IssueListByRepoOptions specifies the optional parameters to the
@@ -208,13 +208,13 @@ func (s *IssuesService) ListByRepo(owner string, repo string, opt *IssueListByRe
208208
// TODO: remove custom Accept header when this API fully launches.
209209
req.Header.Set("Accept", mediaTypeReactionsPreview)
210210

211-
issues := new([]*Issue)
212-
resp, err := s.client.Do(req, issues)
211+
var issues []*Issue
212+
resp, err := s.client.Do(req, &issues)
213213
if err != nil {
214214
return nil, resp, err
215215
}
216216

217-
return *issues, resp, err
217+
return issues, resp, nil
218218
}
219219

220220
// Get a single issue.

‎github/issues_assignees.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ func (s *IssuesService) ListAssignees(owner, repo string, opt *ListOptions) ([]*
2222
if err != nil {
2323
return nil, nil, err
2424
}
25-
assignees := new([]*User)
26-
resp, err := s.client.Do(req, assignees)
25+
var assignees []*User
26+
resp, err := s.client.Do(req, &assignees)
2727
if err != nil {
2828
return nil, resp, err
2929
}
3030

31-
return *assignees, resp, err
31+
return assignees, resp, nil
3232
}
3333

3434
// IsAssignee checks if a user is an assignee for the specified repository.

0 commit comments

Comments
 (0)