Formatting class with a variable/field called "sealed" causes IAE: No enum constant javax.lang.model.element.Modifier.SEALED with Java < 15

[kwin]

When trying to format the following class one runs into an IAE with Java < 15.

package org.test;

public class Test {
    void test() {
        String sealed = "a sealed test";
    }
}

The stacktrace looks like this

java.lang.IllegalArgumentException: No enum constant javax.lang.model.element.Modifier.SEALED
	at java.base/java.lang.Enum.valueOf(Enum.java:240)
	at [email protected]/javax.lang.model.element.Modifier.valueOf(Modifier.java:47)
	at com.google.googlejavaformat.java.ModifierOrderer.asModifier(ModifierOrderer.java:151)
	at com.google.googlejavaformat.java.ModifierOrderer.reorderModifiers(ModifierOrderer.java:79)
	at com.google.googlejavaformat.java.Formatter.getFormatReplacements(Formatter.java:285)
...

The reason is the unconditional call of Modifier.valueOf("sealed") in

google-java-format/core/src/main/java/com/google/googlejavaformat/java/ModifierOrderer.java

Line 241 in ccb56c7

return Modifier.valueOf("SEALED");

which throws this exception on all Java versions below 15.

Although the newest version only supports Java 17 as runtime, this is an issue already with versions which are supposed to support Java 11 as runtime, e.g. < 1.24.0

[kwin]

This is related to #697 however this is about a case where the "sealed" modifier is incorrectly(!) detected. Notice that sealed is not a reserved keyword (https://docs.oracle.com/javase/tutorial/java/nutsandbolts/_keywords.html), so it may be used as variable/field name as well. According to https://docs.oracle.com/javase/specs/jls/se17/jls17.pdf, chapter 3.9 sealed is just a contextual keyword, so there needs to be some proper fallback.

[cushon]

Thanks for the report, I agree this is a bug, and should be handled gracefully when running on older JDK versions.

[cushon]

Although the newest version only supports Java 17 as runtime, this is an issue already with versions which are supposed to support Java 11 as runtime, e.g. < 1.24.0

I agree this is a bug, and should be handled gracefully when running on older JDK versions.

Sorry, I hadn't been thinking about the fact that the minimum supported JDK for the latest releases is JDK 17.

I agree this is a bug with < 1.24.0, but we are not doing update releases of old versions. I think the best option is to update to a newer version of the formatter.