Skip to content

Commit c0f413d

Browse files
committedJan 8, 2024
Remove annotation-only Jars from runtime classpath (in Gradle)
1 parent 1de7270 commit c0f413d

File tree

2 files changed

+12
-51
lines changed

2 files changed

+12
-51
lines changed
 

‎guava/module.json

-42
Original file line numberDiff line numberDiff line change
@@ -112,27 +112,6 @@
112112
"version": {
113113
"requires": "9999.0-empty-to-avoid-conflict-with-guava"
114114
}
115-
},
116-
{
117-
"group": "com.google.code.findbugs",
118-
"module": "jsr305",
119-
"version": {
120-
"requires": "${jsr305.version}"
121-
}
122-
},
123-
{
124-
"group": "org.checkerframework",
125-
"module": "checker-qual",
126-
"version": {
127-
"requires": "${checker.version}"
128-
}
129-
},
130-
{
131-
"group": "com.google.errorprone",
132-
"module": "error_prone_annotations",
133-
"version": {
134-
"requires": "${errorprone.version}"
135-
}
136115
}
137116
],
138117
"files": [
@@ -251,27 +230,6 @@
251230
"version": {
252231
"requires": "9999.0-empty-to-avoid-conflict-with-guava"
253232
}
254-
},
255-
{
256-
"group": "com.google.code.findbugs",
257-
"module": "jsr305",
258-
"version": {
259-
"requires": "${jsr305.version}"
260-
}
261-
},
262-
{
263-
"group": "org.checkerframework",
264-
"module": "checker-qual",
265-
"version": {
266-
"requires": "${checker.version}"
267-
}
268-
},
269-
{
270-
"group": "com.google.errorprone",
271-
"module": "error_prone_annotations",
272-
"version": {
273-
"requires": "${errorprone.version}"
274-
}
275233
}
276234
],
277235
"files": [

‎integration-tests/gradle/build.gradle.kts

+12-9
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,28 @@ val guavaVersionJre =
77
val expectedReducedRuntimeClasspathAndroidVersion =
88
setOf(
99
"guava-${guavaVersionJre.replace("jre", "android")}.jar",
10-
"failureaccess-1.0.2.jar",
11-
"jsr305-3.0.2.jar",
12-
"checker-qual-3.41.0.jar",
13-
"error_prone_annotations-2.23.0.jar",
14-
"listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar"
10+
"failureaccess-1.0.2.jar"
1511
)
1612
val expectedReducedRuntimeClasspathJreVersion =
1713
setOf(
1814
"guava-$guavaVersionJre.jar",
19-
"failureaccess-1.0.2.jar",
15+
"failureaccess-1.0.2.jar"
16+
)
17+
val expectedCompileClasspathAndroidVersion =
18+
expectedReducedRuntimeClasspathAndroidVersion + setOf(
19+
"j2objc-annotations-2.8.jar",
2020
"jsr305-3.0.2.jar",
2121
"checker-qual-3.41.0.jar",
2222
"error_prone_annotations-2.23.0.jar",
2323
"listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar"
2424
)
25-
val expectedCompileClasspathAndroidVersion =
26-
expectedReducedRuntimeClasspathAndroidVersion + setOf("j2objc-annotations-2.8.jar")
2725
val expectedCompileClasspathJreVersion =
28-
expectedReducedRuntimeClasspathJreVersion + setOf("j2objc-annotations-2.8.jar")
26+
expectedReducedRuntimeClasspathJreVersion + setOf(
27+
"j2objc-annotations-2.8.jar",
28+
"jsr305-3.0.2.jar",
29+
"checker-qual-3.33.0.jar",
30+
"error_prone_annotations-2.18.0.jar"
31+
)
2932

3033
val extraLegacyDependencies = setOf("google-collections-1.0.jar")
3134

0 commit comments

Comments
 (0)