Skip to content

Commit 11f22f2

Browse files
HannesWellsameb
authored andcommitted
Make error_prone_annotations dependency optional
Annotations with retention policy are ignored if they cannot be loaded at runtime (at least according to [Stack-Overvflow](https://stackoverflow.com/questions/3567413/why-doesnt-a-missing-annotation-cause-a-classnotfoundexception-at-runtime)). Make the dependency optional to not enforce the presence of error_prone_annotations in a java runtime even if those annotations are not used at all. This is especially useful for OSGi-runtimes where you cannot exclude error_prone_annotations because the corresponding package is specified as mandatory requirement in the MANIFEST.MF. Marking the Maven dependency as optional will also result in the error-prone package requirement being marked as optional. At the moment error_prone_annotations does not come with a OSGi compliant Manifest, which makes it harder to include it in OSGi applications like Eclipse. I already created a PR at error-prone to include the required OSGi headers (see google/error-prone#3903), but not requiring the annotations at all would make it even simpler to use guice within OSGi. Alternatively the dependency could be marked as optional in the OSGi metadata. (cherry-picked into the 6.0 release)
1 parent 611baf6 commit 11f22f2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

core/pom.xml

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
<dependency>
3434
<groupId>com.google.errorprone</groupId>
3535
<artifactId>error_prone_annotations</artifactId>
36+
<optional>true</optional>
3637
</dependency>
3738
<!--
3839
| ASM is embedded by default by the JarJar build profile

0 commit comments

Comments
 (0)