Remove spurious fd.IncRef().

nlacasse · gvisor-bot · commit 366f1a8f1607 · 2020-08-26T12:30:44.000-07:00
PiperOrigin-RevId: 328583461
diff --git a/pkg/sentry/fsimpl/overlay/non_directory.go b/pkg/sentry/fsimpl/overlay/non_directory.go
@@ -121,7 +121,6 @@ func (fd *nonDirectoryFD) OnClose(ctx context.Context) error {
 		fd.cachedFlags = statusFlags
 	}
 	wrappedFD := fd.cachedFD
-	defer wrappedFD.IncRef()
 	fd.mu.Unlock()
 	return wrappedFD.OnClose(ctx)
 }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,6 @@ func (fd *nonDirectoryFD) OnClose(ctx context.Context) error {`
`121`	`121`	`fd.cachedFlags = statusFlags`
`122`	`122`	`}`
`123`	`123`	`wrappedFD := fd.cachedFD`
`124`		`- defer wrappedFD.IncRef()`
`125`	`124`	`fd.mu.Unlock()`
`126`	`125`	`return wrappedFD.OnClose(ctx)`
`127`	`126`	`}`