Skip to content

Commit 8dcb5c4

Browse files
EtiennePerotgvisor-bot
authored andcommitted
Run CUDA tests as part of GPU tests.
Attempt #2. This runs in continuous mode only. PiperOrigin-RevId: 689056926
1 parent 74f6136 commit 8dcb5c4

File tree

4 files changed

+25
-1
lines changed

4 files changed

+25
-1
lines changed

.buildkite/pipeline.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,16 @@ steps:
190190
- make cos-gpu-all-tests
191191
agents:
192192
queue: cos-canary-gpu
193+
- <<: *common
194+
<<: *source_test_continuous
195+
label: ":fish: CUDA tests"
196+
# This is its own test rather than being part of the GPU tests,
197+
# because it takes around 15 minutes to run.
198+
commands:
199+
- make sudo TARGETS=//tools/gpu:main ARGS="install --latest" || cat /var/log/nvidia-installer.log
200+
- make cuda-tests
201+
agents:
202+
queue: gpu
193203
- <<: *common
194204
<<: *source_test_continuous
195205
label: ":screwdriver: All GPU Drivers Test"

.buildkite/release.yaml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,15 @@ steps:
6767
- make gpu-all-tests
6868
agents:
6969
queue: gpu
70+
- <<: *common
71+
label: ":fish: CUDA tests in compatibility-verifying mode"
72+
# This is its own test rather than being part of the GPU tests,
73+
# because it takes around an hour to run.
74+
commands:
75+
- make sudo TARGETS=//tools/gpu:main ARGS="install --latest" || cat /var/log/nvidia-installer.log
76+
- make cuda-tests ARGS="--cuda_verify_compatibility=true"
77+
agents:
78+
queue: gpu
7079
- <<: *common
7180
label: ":screwdriver: All GPU Drivers Test"
7281
commands:

Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,11 @@ cos-gpu-all-tests: gpu-images cos-gpu-smoke-tests $(RUNTIME_BIN)
331331
@$(call sudo,test/gpu:sniffer_test,--runtime=$(RUNTIME) -test.v --cos-gpu $(ARGS))
332332
.PHONY: cos-gpu-all-tests
333333

334+
cuda-tests: load-gpu_cuda-tests
335+
@$(call install_runtime,$(RUNTIME),--nvproxy=true --nvproxy-docker=true)
336+
@$(call sudo,test/gpu:cuda_test,--runtime=$(RUNTIME) -test.v $(ARGS))
337+
.PHONY: cuda-tests
338+
334339
portforward-tests: load-basic_redis load-basic_nginx $(RUNTIME_BIN)
335340
@$(call install_runtime,$(RUNTIME),--network=sandbox)
336341
@$(call sudo,test/root:portforward_test,--runtime=$(RUNTIME) -test.v $(ARGS))

test/gpu/cuda_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,7 @@ func TestCUDA(t *testing.T) {
745745
durationPct := 100.0 * float64(startedAgo) / float64(testDeadline.Sub(testStart))
746746
testLog(t, "[Timing] %d/%d tests (%.1f%%) finished executing. Test started %v ago, deadline in %v (%.1f%%).", testsDone, numTests, donePct, startedAgo.Truncate(time.Second), deadlineIn.Truncate(time.Second), durationPct)
747747
if len(failedTests) > 0 {
748-
testLog(t, "[Failed] %d test failed: %v", len(failedTests), strings.Join(failedTests, ", "))
748+
testLog(t, "[Failed] %d test(s) failed: %v", len(failedTests), strings.Join(failedTests, ", "))
749749
}
750750
testLog(t, "[Pool] %v", cp.String())
751751
}

0 commit comments

Comments
 (0)