Skip to content

Commit b435793

Browse files
arthurpigvisor-bot
authored andcommitted
Re-enable ipv4 reassembly packetimpact tests
When these specific tests were first added, they would fail when ran by kokoro during the presubmit tests (but they always passed locally). These tests are now passing, so they can be re-enabled. Unclear what changed, one hypothesis is the move from kokoro to buildkite. Fixes #4971 PiperOrigin-RevId: 354425395
1 parent 62a3703 commit b435793

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

test/packetimpact/tests/ipv4_fragment_reassembly_test.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ func TestIPv4FragmentReassembly(t *testing.T) {
4545
ipPayloadLen int
4646
fragments []fragmentInfo
4747
expectReply bool
48-
skip bool
49-
skipReason string
5048
}{
5149
{
5250
description: "basic reassembly",
@@ -78,8 +76,6 @@ func TestIPv4FragmentReassembly(t *testing.T) {
7876
{offset: 2000, size: 1000, id: 7, more: 0},
7977
},
8078
expectReply: true,
81-
skip: true,
82-
skipReason: "gvisor.dev/issues/4971",
8379
},
8480
{
8581
description: "fragment subset",
@@ -91,8 +87,6 @@ func TestIPv4FragmentReassembly(t *testing.T) {
9187
{offset: 2000, size: 1000, id: 8, more: 0},
9288
},
9389
expectReply: true,
94-
skip: true,
95-
skipReason: "gvisor.dev/issues/4971",
9690
},
9791
{
9892
description: "fragment overlap",
@@ -104,16 +98,10 @@ func TestIPv4FragmentReassembly(t *testing.T) {
10498
{offset: 2000, size: 1000, id: 9, more: 0},
10599
},
106100
expectReply: false,
107-
skip: true,
108-
skipReason: "gvisor.dev/issues/4971",
109101
},
110102
}
111103

112104
for _, test := range tests {
113-
if test.skip {
114-
t.Skip("%s test skipped: %s", test.description, test.skipReason)
115-
continue
116-
}
117105
t.Run(test.description, func(t *testing.T) {
118106
dut := testbench.NewDUT(t)
119107
conn := dut.Net.NewIPv4Conn(t, testbench.IPv4{}, testbench.IPv4{})

0 commit comments

Comments
 (0)