Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay size, as alternative to --storage-opt size=30G #11504

Open
lukasmrtvy opened this issue Mar 2, 2025 · 4 comments
Open

Overlay size, as alternative to --storage-opt size=30G #11504

lukasmrtvy opened this issue Mar 2, 2025 · 4 comments
Labels
good first issue Good for newcomers type: enhancement New feature or request

Comments

@lukasmrtvy
Copy link

lukasmrtvy commented Mar 2, 2025

Description

Would be superb to support limiting disk space similar to the Docker's --storage-opt size=30G
Thanks

Is this feature related to a specific bug?

No response

Do you have a specific solution in mind?

No response

@lukasmrtvy lukasmrtvy added the type: enhancement New feature or request label Mar 2, 2025
@EtiennePerot EtiennePerot added the good first issue Good for newcomers label Mar 5, 2025
@manojks1999
Copy link

/assign

@ayushr2
Copy link
Collaborator

ayushr2 commented Mar 10, 2025

IIUC Docker's --storage-opt should be working correctly with gVisor too. Are you experiencing a bug with that? Or is this a feature request to "limit disk space" akin to that option?

Limiting disk space depends on the underlying filesystem driver. I think higher-level container runtimes like Docker are the right places to implement this feature.

You can easily limit disk space on tmpfs BTW using the size mount option; see mount(5). gVisor supports this mount option.

@lukasmrtvy
Copy link
Author

@ayushr2 Hi, thanks. The use case would be with Docker + containerd ( https://docs.docker.com/desktop/features/containerd/ ). I have tried a storage-opt size= arg, but it's not working. Maybe this has to be supported directly in containerd snapshotter?

@ayushr2
Copy link
Collaborator

ayushr2 commented Mar 10, 2025

I have tried a storage-opt size= arg, but it's not working.

Is it only not working with gVisor? Or is this not working without gVisor as well?

Maybe this has to be supported directly in containerd snapshotter?

I believe so... the component configuring the host container filesystem has to set disk limits using filesystem driver specific primitives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants