Skip to content

Commit d85dfad

Browse files
tseaverbusunkim96
andauthored
fix: use (new) typing for 'gapic_v1.method.DEFAULT' (#1032)
Relies on merge of googleapis/python-api-core#292, but falls back to current (unsat) typing on older versions. Co-authored-by: Bu Sun Kim <[email protected]>
1 parent a8d2b3a commit d85dfad

File tree

16 files changed

+65
-16
lines changed

16 files changed

+65
-16
lines changed

gapic/ads-templates/%namespace/%name/%version/%sub/services/%service/client.py.j2

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ from google.auth.transport.grpc import SslCredentials # type: ignore
2222
from google.auth.exceptions import MutualTLSChannelError # type: ignore
2323
from google.oauth2 import service_account # type: ignore
2424

25-
OptionalRetry = Union[retries.Retry, object]
25+
try:
26+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
27+
except AttributeError:
28+
OptionalRetry = Union[retries.Retry, object]
2629

2730
{% filter sort_lines %}
2831
{% for method in service.methods.values() %}

gapic/templates/%namespace/%name_%version/%sub/services/%service/async_client.py.j2

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@ from google.api_core import retry as retries # type: ignore
1818
from google.auth import credentials as ga_credentials # type: ignore
1919
from google.oauth2 import service_account # type: ignore
2020

21-
OptionalRetry = Union[retries.Retry, object]
21+
try:
22+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
23+
except AttributeError:
24+
OptionalRetry = Union[retries.Retry, object]
2225

2326
{% filter sort_lines %}
2427
{% for method in service.methods.values() %}

gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ from google.auth.transport.grpc import SslCredentials # type: ignore
2222
from google.auth.exceptions import MutualTLSChannelError # type: ignore
2323
from google.oauth2 import service_account # type: ignore
2424

25-
OptionalRetry = Union[retries.Retry, object]
25+
try:
26+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
27+
except AttributeError:
28+
OptionalRetry = Union[retries.Retry, object]
2629

2730
{% filter sort_lines %}
2831
{% for method in service.methods.values() %}

gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@ from requests import __version__ as requests_version
1515
from typing import Callable, Dict, Optional, Sequence, Tuple, Union
1616
import warnings
1717

18-
OptionalRetry = Union[retries.Retry, object]
18+
try:
19+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
20+
except AttributeError:
21+
OptionalRetry = Union[retries.Retry, object]
22+
1923
{% extends '_base.py.j2' %}
2024

2125
{% block content %}

tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/async_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
from google.auth import credentials as ga_credentials # type: ignore
2727
from google.oauth2 import service_account # type: ignore
2828

29-
OptionalRetry = Union[retries.Retry, object]
29+
try:
30+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
31+
except AttributeError:
32+
OptionalRetry = Union[retries.Retry, object]
3033

3134
from google.api_core import operation # type: ignore
3235
from google.api_core import operation_async # type: ignore

tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
from google.auth.exceptions import MutualTLSChannelError # type: ignore
3131
from google.oauth2 import service_account # type: ignore
3232

33-
OptionalRetry = Union[retries.Retry, object]
33+
try:
34+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
35+
except AttributeError:
36+
OptionalRetry = Union[retries.Retry, object]
3437

3538
from google.api_core import operation # type: ignore
3639
from google.api_core import operation_async # type: ignore

tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/async_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
from google.auth import credentials as ga_credentials # type: ignore
2727
from google.oauth2 import service_account # type: ignore
2828

29-
OptionalRetry = Union[retries.Retry, object]
29+
try:
30+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
31+
except AttributeError:
32+
OptionalRetry = Union[retries.Retry, object]
3033

3134
from google.iam.credentials_v1.types import common
3235
from google.protobuf import duration_pb2 # type: ignore

tests/integration/goldens/credentials/google/iam/credentials_v1/services/iam_credentials/client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
from google.auth.exceptions import MutualTLSChannelError # type: ignore
3131
from google.oauth2 import service_account # type: ignore
3232

33-
OptionalRetry = Union[retries.Retry, object]
33+
try:
34+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
35+
except AttributeError:
36+
OptionalRetry = Union[retries.Retry, object]
3437

3538
from google.iam.credentials_v1.types import common
3639
from google.protobuf import duration_pb2 # type: ignore

tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/async_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
from google.auth import credentials as ga_credentials # type: ignore
2727
from google.oauth2 import service_account # type: ignore
2828

29-
OptionalRetry = Union[retries.Retry, object]
29+
try:
30+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
31+
except AttributeError:
32+
OptionalRetry = Union[retries.Retry, object]
3033

3134
from google.cloud.logging_v2.services.config_service_v2 import pagers
3235
from google.cloud.logging_v2.types import logging_config

tests/integration/goldens/logging/google/cloud/logging_v2/services/config_service_v2/client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
from google.auth.exceptions import MutualTLSChannelError # type: ignore
3131
from google.oauth2 import service_account # type: ignore
3232

33-
OptionalRetry = Union[retries.Retry, object]
33+
try:
34+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
35+
except AttributeError:
36+
OptionalRetry = Union[retries.Retry, object]
3437

3538
from google.cloud.logging_v2.services.config_service_v2 import pagers
3639
from google.cloud.logging_v2.types import logging_config

tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/async_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
from google.auth import credentials as ga_credentials # type: ignore
2727
from google.oauth2 import service_account # type: ignore
2828

29-
OptionalRetry = Union[retries.Retry, object]
29+
try:
30+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
31+
except AttributeError:
32+
OptionalRetry = Union[retries.Retry, object]
3033

3134
from google.api import monitored_resource_pb2 # type: ignore
3235
from google.cloud.logging_v2.services.logging_service_v2 import pagers

tests/integration/goldens/logging/google/cloud/logging_v2/services/logging_service_v2/client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
from google.auth.exceptions import MutualTLSChannelError # type: ignore
3131
from google.oauth2 import service_account # type: ignore
3232

33-
OptionalRetry = Union[retries.Retry, object]
33+
try:
34+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
35+
except AttributeError:
36+
OptionalRetry = Union[retries.Retry, object]
3437

3538
from google.api import monitored_resource_pb2 # type: ignore
3639
from google.cloud.logging_v2.services.logging_service_v2 import pagers

tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/async_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
from google.auth import credentials as ga_credentials # type: ignore
2727
from google.oauth2 import service_account # type: ignore
2828

29-
OptionalRetry = Union[retries.Retry, object]
29+
try:
30+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
31+
except AttributeError:
32+
OptionalRetry = Union[retries.Retry, object]
3033

3134
from google.api import distribution_pb2 # type: ignore
3235
from google.api import metric_pb2 # type: ignore

tests/integration/goldens/logging/google/cloud/logging_v2/services/metrics_service_v2/client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
from google.auth.exceptions import MutualTLSChannelError # type: ignore
3131
from google.oauth2 import service_account # type: ignore
3232

33-
OptionalRetry = Union[retries.Retry, object]
33+
try:
34+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
35+
except AttributeError:
36+
OptionalRetry = Union[retries.Retry, object]
3437

3538
from google.api import distribution_pb2 # type: ignore
3639
from google.api import metric_pb2 # type: ignore

tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/async_client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,10 @@
2626
from google.auth import credentials as ga_credentials # type: ignore
2727
from google.oauth2 import service_account # type: ignore
2828

29-
OptionalRetry = Union[retries.Retry, object]
29+
try:
30+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
31+
except AttributeError:
32+
OptionalRetry = Union[retries.Retry, object]
3033

3134
from google.api_core import operation # type: ignore
3235
from google.api_core import operation_async # type: ignore

tests/integration/goldens/redis/google/cloud/redis_v1/services/cloud_redis/client.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,10 @@
3030
from google.auth.exceptions import MutualTLSChannelError # type: ignore
3131
from google.oauth2 import service_account # type: ignore
3232

33-
OptionalRetry = Union[retries.Retry, object]
33+
try:
34+
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault]
35+
except AttributeError:
36+
OptionalRetry = Union[retries.Retry, object]
3437

3538
from google.api_core import operation # type: ignore
3639
from google.api_core import operation_async # type: ignore

0 commit comments

Comments
 (0)