Skip to content

Code Cleanup: Remove DEFAULT_ENDPOINT from generated clients. #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ohmayr opened this issue Dec 18, 2023 · 0 comments · May be fixed by #2394
Open

Code Cleanup: Remove DEFAULT_ENDPOINT from generated clients. #1894

ohmayr opened this issue Dec 18, 2023 · 0 comments · May be fixed by #2394
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Dec 18, 2023

DEFAULT_ENDPOINT will be deprecated once DEFAULT_ENDPOINT_TEMPLATE is introduced as part of the changes to support the universe domain.

Once those changes are completed, we should remove DEFAULT_ENDPOINT from the jinja templates and update the GAPICs as part of code cleanup.
@ohmayr ohmayr added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. next major: breaking change this is a change that we should wait to bundle into the next major version labels Dec 18, 2023
@ohmayr ohmayr linked a pull request May 20, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove deprecated endpoint code googleapis/gapic-generator-python
1 participant
@ohmayr