Skip to content

The hand-written wrappers of the auto-generated interfaces with 'parent' argument hide it by implicitly substituting preconfigured project id #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
minherz opened this issue Jul 28, 2021 · 4 comments
Closed

The hand-written wrappers of the auto-generated interfaces with 'parent' argument hide it by implicitly substituting preconfigured project id #597

minherz opened this issue Jul 28, 2021 · 4 comments
Assignees
@minherz
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@minherz
Copy link
Contributor

minherz commented Jul 28, 2021

Auto-generated interfaces (under proto-google-cloud-logging-v2/src/main/java/com/google/logging/v2/) have required parameter 'parent' which is implicitly substituted with a project id which is detected from environment or credentials and do not allow explicitly define it via call arguments.
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jul 28, 2021
@minherz minherz added lang: java Issues specific to Java. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 28, 2021
@minherz minherz assigned minherz and unassigned simonz130 Jul 28, 2021
@minherz
Copy link
Contributor Author

minherz commented Jul 28, 2021

We need review all interfaces in Logging.java and modify *Option argument types to allow parent parameter.
And then we need to use the parameter with a project id from credentials to be used as a fallback if the parameter is omitted.

@minherz minherz added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 2, 2021
@minherz
Copy link
Contributor Author

minherz commented Aug 2, 2021 •
edited
Loading

Downgrading priority to 3 since there are no developer requests to provide more customization

@minherz
Copy link
Contributor Author

minherz commented Aug 11, 2021

A customer submitted PR to googleapis/java-logging-logback#371 that allows customizing a project id.
@simonz130 WDYT about fixing this? Do we need PRD?

@minherz minherz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 23, 2021
@minherz minherz changed the title bug: The hand-written wrappers of the auto-generated interfaces with 'parent' argument hide it by implicitly substituting preconfigured project id The hand-written wrappers of the auto-generated interfaces with 'parent' argument hide it by implicitly substituting preconfigured project id Sep 30, 2021
@minherz
Copy link
Contributor Author

minherz commented Sep 30, 2021

Partially duplicates #684 .
It looks like there is no demand like this for other interfaces.

@minherz minherz closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@minherz @simonz130