Skip to content

non-ASCII Unicode characters in code #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cushon opened this issue Apr 29, 2025 · 0 comments · Fixed by #3844
Closed

non-ASCII Unicode characters in code #3843

cushon opened this issue Apr 29, 2025 · 0 comments · Fixed by #3844
Assignees
@rahul2393
Labels
api: spanner Issues related to the googleapis/java-spanner API.

Comments

@cushon
Copy link
Contributor

cushon commented Apr 29, 2025

There's an unnecessary non-ASCII Unicode character here:

  List<UUID> getUuidList(String columnNameÏ);

https://github.com/googleapis/java-spanner/blame/4f63109077cb7317eb18d074837b6d1c832f9420/google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java#L651

This is discouraged by https://errorprone.info/bugpattern/UnicodeInCode

It looks like the character might have been a typo.
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 29, 2025
@cushon cushon mentioned this issue Apr 29, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the googleapis/java-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: non-ASCII Unicode characters in code cushon/java-spanner
2 participants
@cushon @rahul2393