Skip to content

feat: enable AFE and gRPC metrics for DP #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 9, 2025
Merged

Conversation

surbhigarg92
Copy link
Contributor

@surbhigarg92 surbhigarg92 commented May 8, 2025

Enable gRPC/AFE built-in metrics if:

  1. The env var SPANNER_DISABLE_DIRECT_ACCESS_GRPC_BUILTIN_METRICS / SPANNER_DISABLE_AFE_SERVER_TIMING is explicitly set to "false", OR
  2. DirectPath is enabled AND the env var is not set to "true". This allows metrics to be enabled by default when DirectPath is on, unless explicitly disabled via env.

This PR also skips GFE metrics when DirectPath is used.

@surbhigarg92 surbhigarg92 requested review from a team as code owners May 8, 2025 09:26
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels May 8, 2025
@surbhigarg92 surbhigarg92 changed the title feat:enable AFE and gRPC metrics for DP feat: enable AFE and gRPC metrics for DP May 8, 2025
@surbhigarg92 surbhigarg92 force-pushed the enable_metrics_for_DP branch from 0c03b8e to e4957f7 Compare May 8, 2025 09:41
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 8, 2025
@surbhigarg92 surbhigarg92 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 8, 2025
@rahul2393 rahul2393 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 9, 2025
@surbhigarg92 surbhigarg92 force-pushed the enable_metrics_for_DP branch from 92c9355 to 479b6d5 Compare May 9, 2025 05:48
@surbhigarg92 surbhigarg92 force-pushed the enable_metrics_for_DP branch from a7dd7b5 to c2e6c0f Compare May 9, 2025 06:44
@rahul2393 rahul2393 requested a review from sakthivelmanii May 9, 2025 07:38
@rahul2393 rahul2393 merged commit 203baae into main May 9, 2025
37 checks passed
@rahul2393 rahul2393 deleted the enable_metrics_for_DP branch May 9, 2025 09:29
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 9, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`6.92.0` -> `6.93.0` |

---

### Release Notes

<details>
<summary>googleapis/java-spanner
(com.google.cloud:google-cloud-spanner)</summary>

###
[`v6.93.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6930-2025-05-09)

##### Features

- Enable AFE and gRPC metrics for DP
([#&#8203;3852](googleapis/java-spanner#3852))
([203baae](googleapis/java-spanner@203baae))

##### Bug Fixes

- Change server timing duration attribute to float as per w3c
([#&#8203;3851](googleapis/java-spanner#3851))
([da8dd8d](googleapis/java-spanner@da8dd8d))
- **deps:** Update the Java code generator (gapic-generator-java) to
2.57.0
([23b985c](googleapis/java-spanner@23b985c))
- Non-ASCII Unicode characters in code
([#&#8203;3844](googleapis/java-spanner#3844))
([85a0820](googleapis/java-spanner@85a0820))
- Only close and return sessions once
([#&#8203;3846](googleapis/java-spanner#3846))
([32b2373](googleapis/java-spanner@32b2373))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: bcf762c4aff746876d98c5fcd10f568fa9f00651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants