fix: change REST binding for ListDocuments to support root collection (#1695)

Author: gcf-owl-bot[bot]

dev/protos/google/firestore/v1/common.proto

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2022 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -17,7 +17,6 @@ syntax = "proto3";
 package google.firestore.v1;
 
 import "google/protobuf/timestamp.proto";
-import "google/api/annotations.proto";
 
 option csharp_namespace = "Google.Cloud.Firestore.V1";
 option go_package = "google.golang.org/genproto/googleapis/firestore/v1;firestore";
@@ -48,7 +47,7 @@ message Precondition {
     bool exists = 1;
 
     // When set, the target document must exist and have been last updated at
-    // that time.
+    // that time. Timestamp must be microsecond aligned.
     google.protobuf.Timestamp update_time = 2;
   }
 }

dev/protos/google/firestore/v1/document.proto

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2022 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -19,7 +19,6 @@ package google.firestore.v1;
 import "google/protobuf/struct.proto";
 import "google/protobuf/timestamp.proto";
 import "google/type/latlng.proto";
-import "google/api/annotations.proto";
 
 option csharp_namespace = "Google.Cloud.Firestore.V1";
 option go_package = "google.golang.org/genproto/googleapis/firestore/v1;firestore";

dev/protos/google/firestore/v1/firestore.proto

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2022 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -32,7 +32,6 @@ option go_package = "google.golang.org/genproto/googleapis/firestore/v1;firestor
 option java_multiple_files = true;
 option java_outer_classname = "FirestoreProto";
 option java_package = "com.google.firestore.v1";
-option objc_class_prefix = "GCFS";
 option php_namespace = "Google\\Cloud\\Firestore\\V1";
 option ruby_package = "Google::Cloud::Firestore::V1";
 
@@ -63,6 +62,9 @@ service Firestore {
   rpc ListDocuments(ListDocumentsRequest) returns (ListDocumentsResponse) {
     option (google.api.http) = {
       get: "/v1/{parent=projects/*/databases/*/documents/*/**}/{collection_id}"
+      additional_bindings {
+        get: "/v1/{parent=projects/*/databases/*/documents}/{collection_id}"
+      }
     };
   }
 
@@ -481,7 +483,9 @@ message RunQueryRequest {
   // The consistency mode for this transaction.
   // If not set, defaults to strong consistency.
   oneof consistency_selector {
-    // Reads documents in a transaction.
+    // Run the query within an already active transaction.
+    //
+    // The value here is the opaque transaction ID to execute the query in.
     bytes transaction = 5;
 
     // Starts a new transaction and reads the documents.
@@ -504,8 +508,7 @@ message RunQueryResponse {
   // If set, no other fields will be set in this response.
   bytes transaction = 2;
 
-  // A query result.
-  // Not set when reporting partial progress.
+  // A query result, not set when reporting partial progress.
   Document document = 1;
 
   // The time at which the document was read. This may be monotonically

dev/protos/google/firestore/v1/query.proto

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2022 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -16,9 +16,9 @@ syntax = "proto3";
 
 package google.firestore.v1;
 
+import "google/api/field_behavior.proto";
 import "google/firestore/v1/document.proto";
 import "google/protobuf/wrappers.proto";
-import "google/api/annotations.proto";
 
 option csharp_namespace = "Google.Cloud.Firestore.V1";
 option go_package = "google.golang.org/genproto/googleapis/firestore/v1;firestore";
@@ -213,6 +213,18 @@ message StructuredQuery {
     Direction direction = 2;
   }
 
+  // A sort direction.
+  enum Direction {
+    // Unspecified.
+    DIRECTION_UNSPECIFIED = 0;
+
+    // Ascending.
+    ASCENDING = 1;
+
+    // Descending.
+    DESCENDING = 2;
+  }
+
   // A reference to a field, such as `max(messages.time) as max_time`.
   message FieldReference {
     string field_path = 2;
@@ -227,18 +239,6 @@ message StructuredQuery {
     repeated FieldReference fields = 2;
   }
 
-  // A sort direction.
-  enum Direction {
-    // Unspecified.
-    DIRECTION_UNSPECIFIED = 0;
-
-    // Ascending.
-    ASCENDING = 1;
-
-    // Descending.
-    DESCENDING = 2;
-  }
-
   // The projection to return.
   Projection select = 1;
 

dev/protos/google/firestore/v1/write.proto

@@ -1,4 +1,4 @@
-// Copyright 2021 Google LLC
+// Copyright 2022 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -19,7 +19,6 @@ package google.firestore.v1;
 import "google/firestore/v1/common.proto";
 import "google/firestore/v1/document.proto";
 import "google/protobuf/timestamp.proto";
-import "google/api/annotations.proto";
 
 option csharp_namespace = "Google.Cloud.Firestore.V1";
 option go_package = "google.golang.org/genproto/googleapis/firestore/v1;firestore";

dev/src/v1/firestore_client.ts

@@ -1186,7 +1186,9 @@ export class FirestoreClient {
    * @param {google.firestore.v1.StructuredQuery} request.structuredQuery
    *   A structured query.
    * @param {Buffer} request.transaction
-   *   Reads documents in a transaction.
+   *   Run the query within an already active transaction.
+   *
+   *   The value here is the opaque transaction ID to execute the query in.
    * @param {google.firestore.v1.TransactionOptions} request.newTransaction
    *   Starts a new transaction and reads the documents.
    *   Defaults to a read-only transaction.