Skip to content

Commit b778d5f

Browse files
committed
chore: avoid duplicating pins of grpcio
Rely on the pins in as the Source of Truth. See #234 (review)
1 parent 6789e67 commit b778d5f

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

noxfile.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ def default(session):
8080
)
8181

8282
# Install all test dependencies, then install this package in-place.
83-
session.install("mock", "pytest", "pytest-cov", "grpcio >= 1.0.2")
84-
session.install("-e", ".", "-c", constraints_path)
83+
session.install("mock", "pytest", "pytest-cov")
84+
session.install("-e", ".[grpc]", "-c", constraints_path)
8585

8686
pytest_args = [
8787
"python",
@@ -124,7 +124,7 @@ def unit_grpc_gcp(session):
124124
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
125125
)
126126
# Install grpcio-gcp
127-
session.install("grpcio-gcp", "-c", constraints_path)
127+
session.install("-e", ".[grpcgcp]", "-c", constraints_path)
128128

129129
default(session)
130130

@@ -141,9 +141,7 @@ def lint_setup_py(session):
141141
@nox.session(python="3.6")
142142
def pytype(session):
143143
"""Run type-checking."""
144-
session.install(
145-
".", "grpcio >= 1.8.2", "grpcio-gcp >= 0.2.2", "pytype >= 2019.3.21"
146-
)
144+
session.install(".[grpc, grpcgcp]", "pytype >= 2019.3.21")
147145
session.run("pytype")
148146

149147

@@ -163,8 +161,7 @@ def cover(session):
163161
def docs(session):
164162
"""Build the docs for this library."""
165163

166-
session.install(".", "grpcio >= 1.8.2", "grpcio-gcp >= 0.2.2")
167-
session.install("-e", ".")
164+
session.install("-e", ".[grpc, grpcgcp]")
168165
session.install("sphinx==4.0.1", "alabaster", "recommonmark")
169166

170167
shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)

0 commit comments

Comments
 (0)