Skip to content

client_info from start_rpc arg should be used when creating BidiRpc #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
busunkim96 opened this issue Jun 8, 2021 · 1 comment
Closed

client_info from start_rpc arg should be used when creating BidiRpc #202

busunkim96 opened this issue Jun 8, 2021 · 1 comment
Assignees
@busunkim96
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@busunkim96
Copy link
Contributor

python-api-core/google/api_core/bidi.py

Line 246 in 9eaa786

def __init__(self, start_rpc, initial_request=None, metadata=None):

GAPIC clients add client_info metadata to rpcs when the methods are wrapped. BidiRPC should use this start rpc's metadata if metadata is not passed to the constructor.

CC @jameslynnwu
@busunkim96 busunkim96 self-assigned this Jun 8, 2021
@busunkim96 busunkim96 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 8, 2021
This was referenced Jun 10, 2021
Closed
Closed
@parthea
Copy link
Collaborator

parthea commented Oct 31, 2024

Closing as obsolete. This appears to be working.

@parthea parthea closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Bidi uses metadata from start_rpc googleapis/python-api-core
2 participants
@parthea @busunkim96