Skip to content

Feat: Add support for universe_domain as a client option for TPC #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ohmayr opened this issue Nov 7, 2023 · 0 comments · Fixed by #546
Closed

Feat: Add support for universe_domain as a client option for TPC #547

ohmayr opened this issue Nov 7, 2023 · 0 comments · Fixed by #546
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Nov 7, 2023

universe_domain is required as an optional field in google.api_core.ClientOptions to enable users to explicitly configure universe domain as a client option.

This will enable API endpoint to be resolved using a templated value if a universe domain is specified or otherwise default to GDU.

# user configures the universe domain:
client = Client(google.api_core.ClientOptions{universe_domain="foo.com"})

# api_endpoint points to the TPC universe:
api_endpoint = "service.foo.com"
# user does not configure the universe domain:
client = Client(google.api_core.ClientOptions{})

# api_endpoint defaults to GDU:
api_endpoint = "service.googleapis.com"
@vchudnov-g vchudnov-g added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants