Skip to content

Undeclared dependency on proto-plus #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea opened this issue Feb 29, 2024 · 0 comments · Fixed by #626
Closed

Undeclared dependency on proto-plus #625

parthea opened this issue Feb 29, 2024 · 0 comments · Fixed by #626
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Collaborator

parthea commented Feb 29, 2024

In #604, import proto was added to google/api_core/rest_streaming.py however the dependency was not added to setup.py. See bcebc92#r139197223 where the issue was reported.

python-api-core/google/api_core/rest_streaming.py

Line 21 in 475ff2e

import proto

@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 29, 2024
@parthea parthea mentioned this issue Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): Require proto-plus >= 1.22.3 googleapis/python-api-core
1 participant
@parthea