Skip to content

BUG: potential resource leak when using BigQuery Storage API #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tswast opened this issue Nov 8, 2019 · 0 comments · Fixed by #295
Closed

BUG: potential resource leak when using BigQuery Storage API #294

tswast opened this issue Nov 8, 2019 · 0 comments · Fixed by #295
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link
Collaborator

tswast commented Nov 8, 2019

It came to my attention in googleapis/google-cloud-python#9457 that when a gRPC Google Cloud client object is destroyed, it doesn't clean up all the underlying resources from the gRPC transport layer.

I'd like to address this at the Google Cloud client level by providing better support for short-lived gRPC clients, but in the meantime, we need to call bqstorage_client.transport.close() when we are done using a BigQuery Storage API client.

@tswast tswast added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant