feature: raise error for unknown properties in job config (#446)

* feature: warn about unknown properties in job config

* fix: raise error instead of warning

* fix: use hasattr instead of __dict__

* fix bad merge

* fix system test that sets wrong property

Co-authored-by: Tim Swast <[email protected]>

Author: cguardia

google/cloud/bigquery/job/base.py

@@ -659,6 +659,14 @@ def __init__(self, job_type, **kwargs):
         for prop, val in kwargs.items():
             setattr(self, prop, val)
 
+    def __setattr__(self, name, value):
+        """Override to be able to raise error if an unknown property is being set"""
+        if not name.startswith("_") and not hasattr(type(self), name):
+            raise AttributeError(
+                "Property {} is unknown for {}.".format(name, type(self))
+            )
+        super(_JobConfig, self).__setattr__(name, value)
+
     @property
     def labels(self):
         """Dict[str, str]: Labels for the job.

tests/system.py

@@ -76,7 +76,7 @@
 from google.cloud.bigquery.dataset import DatasetReference
 from google.cloud.bigquery.table import Table
 from google.cloud._helpers import UTC
-from google.cloud.bigquery import dbapi
+from google.cloud.bigquery import dbapi, enums
 from google.cloud import storage
 
 from test_utils.retry import RetryErrors
@@ -1789,10 +1789,8 @@ def test_query_w_wrong_config(self):
         rows = list(Config.CLIENT.query("SELECT 1;").result())
         assert rows[0][0] == 1
 
-        project = Config.CLIENT.project
-        dataset_ref = bigquery.DatasetReference(project, "dset")
         bad_config = LoadJobConfig()
-        bad_config.destination = dataset_ref.table("tbl")
+        bad_config.source_format = enums.SourceFormat.CSV
         with self.assertRaises(Exception):
             Config.CLIENT.query(good_query, job_config=bad_config).result()
 

tests/unit/job/test_base.py

@@ -19,6 +19,7 @@
 from google.api_core import exceptions
 import google.api_core.retry
 import mock
+import pytest
 
 from .helpers import _make_client
 from .helpers import _make_connection
@@ -1021,6 +1022,12 @@ def test_ctor(self):
         self.assertEqual(job_config._job_type, self.JOB_TYPE)
         self.assertEqual(job_config._properties, {self.JOB_TYPE: {}})
 
+    def test_ctor_with_unknown_property_raises_error(self):
+        error_text = "Property wrong_name is unknown for"
+        with pytest.raises(AttributeError, match=error_text):
+            config = self._make_one()
+            config.wrong_name = None
+
     def test_fill_from_default(self):
         from google.cloud.bigquery import QueryJobConfig