Skip to content

Commit 319fa54

Browse files
fix: Add async context manager return types (#434)
* fix: Add async context manager return types chore: Mock return_value should not populate oneof message fields chore: Support snippet generation for services that only support REST transport chore: Update gapic-generator-python to v1.11.0 PiperOrigin-RevId: 545430278 Source-Link: googleapis/googleapis@601b532 Source-Link: googleapis/googleapis-gen@b3f18d0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 78e3d3a commit 319fa54

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

google/cloud/errorreporting_v1beta1/services/error_group_service/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ async def sample_update_group():
427427
# Done; return the response.
428428
return response
429429

430-
async def __aenter__(self):
430+
async def __aenter__(self) -> "ErrorGroupServiceAsyncClient":
431431
return self
432432

433433
async def __aexit__(self, exc_type, exc, tb):

google/cloud/errorreporting_v1beta1/services/error_stats_service/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ async def sample_delete_events():
597597
# Done; return the response.
598598
return response
599599

600-
async def __aenter__(self):
600+
async def __aenter__(self) -> "ErrorStatsServiceAsyncClient":
601601
return self
602602

603603
async def __aexit__(self, exc_type, exc, tb):

google/cloud/errorreporting_v1beta1/services/report_errors_service/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ async def sample_report_error_event():
348348
# Done; return the response.
349349
return response
350350

351-
async def __aenter__(self):
351+
async def __aenter__(self) -> "ReportErrorsServiceAsyncClient":
352352
return self
353353

354354
async def __aexit__(self, exc_type, exc, tb):

samples/generated_samples/snippet_metadata_google.devtools.clouderrorreporting.v1beta1.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
],
99
"language": "PYTHON",
1010
"name": "google-cloud-error-reporting",
11-
"version": "1.9.1"
11+
"version": "0.1.0"
1212
},
1313
"snippets": [
1414
{

tests/unit/gapic/errorreporting_v1beta1/test_error_stats_service.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,9 +1178,11 @@ async def test_list_group_stats_async_pages():
11781178
RuntimeError,
11791179
)
11801180
pages = []
1181-
async for page_ in (
1181+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1182+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1183+
async for page_ in ( # pragma: no branch
11821184
await client.list_group_stats(request={})
1183-
).pages: # pragma: no branch
1185+
).pages:
11841186
pages.append(page_)
11851187
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
11861188
assert page_.raw_page.next_page_token == token
@@ -1608,9 +1610,11 @@ async def test_list_events_async_pages():
16081610
RuntimeError,
16091611
)
16101612
pages = []
1611-
async for page_ in (
1613+
# Workaround issue in python 3.9 related to code coverage by adding `# pragma: no branch`
1614+
# See https://github.com/googleapis/gapic-generator-python/pull/1174#issuecomment-1025132372
1615+
async for page_ in ( # pragma: no branch
16121616
await client.list_events(request={})
1613-
).pages: # pragma: no branch
1617+
).pages:
16141618
pages.append(page_)
16151619
for page_, token in zip(pages, ["abc", "def", "ghi", ""]):
16161620
assert page_.raw_page.next_page_token == token

0 commit comments

Comments
 (0)