Skip to content

Commit 6959345

Browse files
fix: Added type hints to CloudLoggingHandler constructor (#903)
* fix: Added type hints to CloudLoggingHandler constructor * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Removed Client typing due to circular imports --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent a49f78c commit 6959345

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

google/cloud/logging_v2/handlers/handlers.py

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,19 @@
1818
import json
1919
import logging
2020

21-
from google.cloud.logging_v2.handlers.transports import BackgroundThreadTransport
21+
from typing import Optional, IO
22+
23+
from google.cloud.logging_v2.handlers.transports import (
24+
BackgroundThreadTransport,
25+
Transport,
26+
)
2227
from google.cloud.logging_v2.handlers._monitored_resources import (
2328
detect_resource,
2429
add_resource_labels,
2530
)
2631
from google.cloud.logging_v2.handlers._helpers import get_request_data
32+
from google.cloud.logging_v2.resource import Resource
33+
2734

2835
DEFAULT_LOGGER_NAME = "python"
2936

@@ -149,11 +156,11 @@ def __init__(
149156
self,
150157
client,
151158
*,
152-
name=DEFAULT_LOGGER_NAME,
153-
transport=BackgroundThreadTransport,
154-
resource=None,
155-
labels=None,
156-
stream=None,
159+
name: str = DEFAULT_LOGGER_NAME,
160+
transport: Transport = BackgroundThreadTransport,
161+
resource: Resource = None,
162+
labels: Optional[dict] = None,
163+
stream: Optional[IO] = None,
157164
**kwargs,
158165
):
159166
"""

0 commit comments

Comments
 (0)